Attachment 44956 Details for Bug 15208 – Bug 15208: Ease translation for shelves messages

[patch] Bug 15208: Ease translation for shelves messages

Bug-15208-Ease-translation-for-shelves-messages.patch (text/plain), 9.43 KB, created by Bernardo Gonzalez Kriegel on 2015-11-18 13:39:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bernardo Gonzalez Kriegel

Created: 2015-11-18 13:39:05 UTC

Size: 9.43 KB

patch

obsolete

>From 1882914914cb2d032f6707fa3ab3fb5df622640c Mon Sep 17 00:00:00 2001
>From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Date: Wed, 18 Nov 2015 10:18:14 -0300
>Subject: [PATCH] Bug 15208: Ease translation for shelves messages
>
>This string patch only puts ...
>around shelves messages. It split a monster
>translation string into its components.
>This kind of string to translate is error-prone.
>
>Also fixed a typo on opac, 'deleteing'
>
>To test:
>1) Search for 'An error occurred when updating this list'
>on your preferred language translation file for staff
>or opac
>(xx-YY-staff-prog.po or xx-YY-opac-bootstrap.po)
>You will see a 'big' string to translate
>
>2) Apply the patch
>
>3) Update translation files for your language
>
>4) Search again, big one is gone and there are
>new individual strings to translate.
>
>Sorry for not spotting this before string freeze
>---
> .../prog/en/modules/virtualshelves/shelves.tt | 36 +++++++++----------
> .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 40 +++++++++++-----------
> 2 files changed, 38 insertions(+), 38 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>index e710e58..fac9ede 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>@@ -322,41 +322,41 @@ function placeHold () {
> <div class="dialog [% m.type %]">
> [% SWITCH m.code %]
> [% CASE 'error_on_update' %]
>- An error occurred when updating this list. Perhaps the value already exists.
>+ An error occurred when updating this list. Perhaps the value already exists.
> [% CASE 'error_on_insert' %]
>- An error occurred when inserting this list. Perhaps the name already exists.
>+ An error occurred when inserting this list. Perhaps the name already exists.
> [% CASE 'error_on_delete' %]
>- An error occurred when deleting this list. Check the logs.
>+ An error occurred when deleting this list. Check the logs.
> [% CASE 'error_on_add_biblio' %]
>- The item has not been added to the list. Please check it's not in this list yet.
>+ The item has not been added to the list. Please check it's not in this list yet.
> [% CASE 'success_on_update' %]
>- List updated with success.
>+ List updated with success.
> [% CASE 'success_on_insert' %]
>- List inserted with success.
>+ List inserted with success.
> [% CASE 'success_on_delete' %]
>- List deleted with success.
>+ List deleted with success.
> [% CASE 'success_on_add_biblio' %]
>- The item has been added to the list.
>+ The item has been added to the list.
> [% CASE 'success_on_remove_biblios' %]
>- The item has been removed from the list.
>+ The item has been removed from the list.
> [% CASE 'does_not_exist' %]
>- This list does not exist.
>+ This list does not exist.
> [% CASE 'item_does_not_exist' %]
>- This item does not exist.
>+ This item does not exist.
> [% CASE 'unauthorized_on_view' %]
>- You do not have permission to view this list.
>+ You do not have permission to view this list.
> [% CASE 'unauthorized_on_update' %]
>- You do not have permission to update this list.
>+ You do not have permission to update this list.
> [% CASE 'unauthorized_on_delete' %]
>- You do not have permission to delete this list.
>+ You do not have permission to delete this list.
> [% CASE 'unauthorized_on_add_biblio' %]
>- You do not have permission to add a biblio to this list.
>+ You do not have permission to add a biblio to this list.
> [% CASE 'no_biblio_removed' %]
>- No biblio has been removed.
>+ No biblio has been removed.
> [% CASE 'Koha::Exceptions::Virtualshelves::DuplicateObject' %]
>- An error occurred when inserting this list. The name already [% shelfname %] exists.
>+ An error occurred when inserting this list. The name already [% shelfname %] exists.
> [% CASE 'Koha::Exceptions::Virtualshelves::UseDbAdminAccount' %]
>- List could not be created. (Do not use the database administrator account.).
>+ List could not be created. (Do not use the database administrator account.)
> [% CASE 'DBIx::Class::Exception' %]
> [% m.msg %]
> [% CASE %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>index 113c056..ae628fa 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>@@ -105,45 +105,45 @@
> [% END %]
> [% SWITCH m.code %]
> [% CASE 'error_on_update' %]
>- An error occurred when updating this list. Perhaps the value already exists.
>+ An error occurred when updating this list. Perhaps the value already exists.
> [% CASE 'error_on_insert' %]
>- An error occurred when inserting this list. Perhaps the name already exists.
>+ An error occurred when inserting this list. Perhaps the name already exists.
> [% CASE 'error_on_delete' %]
>- An error occurred when deleteing this list. Check the logs.
>+ An error occurred when deleting this list. Check the logs.
> [% CASE 'error_on_add_biblio' %]
>- The item has not been added to the list. Please check it's not in this list yet.
>+ The item has not been added to the list. Please check it's not in this list yet.
> [% CASE 'error_on_remove_share' %]
>- The share has not been removed.
>+ The share has not been removed.
> [% CASE 'success_on_update' %]
>- List updated with success.
>+ List updated with success.
> [% CASE 'success_on_insert' %]
>- List inserted with success.
>+ List inserted with success.
> [% CASE 'success_on_delete' %]
>- List deleted with success.
>+ List deleted with success.
> [% CASE 'success_on_add_biblio' %]
>- The item has been added to the list.
>+ The item has been added to the list.
> [% CASE 'success_on_remove_biblios' %]
>- The item has been removed from the list.
>+ The item has been removed from the list.
> [% CASE 'success_on_remove_share' %]
>- The share has been removed.
>+ The share has been removed.
> [% CASE 'does_not_exist' %]
>- This list does not exist.
>+ This list does not exist.
> [% CASE 'item_does_not_exist' %]
>- This item does not exist.
>+ This item does not exist.
> [% CASE 'unauthorized_on_view' %]
>- You do not have permission to view this list.
>+ You do not have permission to view this list.
> [% CASE 'unauthorized_on_insert' %]
>- You do not have permission to insert a new list.
>+ You do not have permission to insert a new list.
> [% CASE 'unauthorized_on_update' %]
>- You do not have permission to update this list.
>+ You do not have permission to update this list.
> [% CASE 'unauthorized_on_delete' %]
>- You do not have permission to delete this list.
>+ You do not have permission to delete this list.
> [% CASE 'unauthorized_on_add_biblio' %]
>- You do not have permission to add a biblio to this list.
>+ You do not have permission to add a biblio to this list.
> [% CASE 'no_biblio_removed' %]
>- No biblio has been removed.
>+ No biblio has been removed.
> [% CASE 'Koha::Exceptions::Virtualshelves::DuplicateObject' %]
>- An error occurred when inserting this list. The name already [% shelfname %] exists.
>+ An error occurred when inserting this list. The name already [% shelfname %] exists.
> [% CASE 'DBIx::Class::Exception' %]
> [% m.msg %]
> [% CASE %]
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 15208: 44956 | 44957 | 44961 | 44962 | 44968 | 44969