Attachment 44958 Details for Bug 15091 – Bug 15091: Do not allow to use batch checkout if checkout is not allowed

[patch] Bug 15091: Do not allow to use batch checkout if checkout is not allowed

Bug-15091-Do-not-allow-to-use-batch-checkout-if-ch.patch (text/plain), 1.92 KB, created by Marc Véron on 2015-11-18 14:37:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2015-11-18 14:37:39 UTC

Size: 1.92 KB

patch

obsolete

>From 1a98d5e8f94195a3ddf5e4c8a10e596d0d3d5107 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 5 Nov 2015 09:58:34 +0000
>Subject: [PATCH] Bug 15091: Do not allow to use batch checkout if checkout is
> not allowed
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>If the noissue param is passed to the template, the batch checkout
>should not be allowed.
>
>This patch globally fixes the problem raised by bug 15091.
>A generic message "cannot check out" is displayed and some more specific
>ones could be added later.
>For now it only trigger the "fine balance is over the limit" message.
>
>Test plan:
>Confirm there is no regression on the original behavior and that the
>issue raised on bug 15091 is fixed.
>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>---
> .../prog/en/modules/circ/circulation_batch_checkouts.tt         |    7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt
>index ade63f6..cf04b5e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt
>@@ -63,6 +63,13 @@ $(document).ready(function() {
> 
> [% IF NOT batch_allowed %]
>   <div class="dialog message">You are not allowed to use batch checkout for this patron</div>
>+[% ELSIF noissues and not checkout_infos %]
>+  <div class="dialog message">
>+    Cannot check out!
>+    [% IF charges_is_blocker %]
>+      Checkouts are <span class="circ-hlt">BLOCKED</span> because fine balance is <span class="circ-hlt">OVER THE LIMIT</span>.
>+    [% END %]
>+  </div>
> [% ELSIF NOT checkout_infos %]
>   <form method="post" enctype="multipart/form-data" action="/cgi-bin/koha/circ/circulation.pl">
>     <fieldset id="circ_circulation_issue">
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 15091: 44212 | 44340 | 44343 | 44344 | 44345 | 44346 | 44465 | 44491 | 44492 | 44958 | 44959 | 44981 | 44982 | 44983