Attachment 4503 Details for Bug 6518 – Bug 6518 : XSS errors

[patch] Bug 6518 : XSS errors

Bug-6518--XSS-errors.patch (text/plain), 6.33 KB, created by Chris Cormack on 2011-06-19 10:04:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2011-06-19 10:04:54 UTC

Size: 6.33 KB

patch

obsolete

>From edbd9dbcb738f3f38b7f946f27c55445140580ca Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chrisc@catalyst.net.nz>
>Date: Fri, 17 Jun 2011 11:04:23 +1200
>Subject: [PATCH] Bug 6518 : XSS errors
>
>---
> .../prog/en/modules/opac-addbybiblionumber.tmpl    |    2 +-
> .../prog/en/modules/opac-downloadcart.tmpl         |    2 +-
> .../prog/en/modules/opac-downloadshelf.tmpl        |    2 +-
> .../opac-tmpl/prog/en/modules/opac-review.tmpl     |    6 +++---
> .../prog/en/modules/opac-serial-issues.tmpl        |    4 ++--
> 5 files changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-addbybiblionumber.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-addbybiblionumber.tmpl
>index 510b12d..982dbeb 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-addbybiblionumber.tmpl
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-addbybiblionumber.tmpl
>@@ -66,7 +66,7 @@
> 		<option value="1">Private</option>
> 		<option value="2">Public</option>
> 		</select></li></ol></fieldset>
>-		 <input type="hidden" name="biblionumber" value="" />
>+		 <input type="hidden"name="biblionumber" value="" />
> 		<fieldset class="action"><input type="submit" value="Save" class="submit" /> <a class="close cancel" href="#">Cancel</a></fieldset>
> 		</form>
> 	
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-downloadcart.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-downloadcart.tmpl
>index 75adf24..3b65f37 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-downloadcart.tmpl
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-downloadcart.tmpl
>@@ -19,7 +19,7 @@
> 	</select></li></ol>
> </fieldset>
> <fieldset class="action">
>-	<input type="hidden" name="bib_list" value="" />
>+	<input type="hidden" name="bib_list" value="" />
> 	<input type="submit" name="save" value="Go" />
> </fieldset>
>     </form>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-downloadshelf.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-downloadshelf.tmpl
>index 1398cd0..3e78e74 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-downloadshelf.tmpl
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-downloadshelf.tmpl
>@@ -24,7 +24,7 @@
> 
> 	</select></li></ol>
> </fieldset>
>-<fieldset class="action">	<input type="hidden" name="shelfid" value="" />
>+<fieldset class="action">	<input type="hidden" name="shelfid" value="" />
> 	<input type="submit" name="save" value="Go" /></fieldset>
>     </form>
> 
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tmpl
>index 573295e..07d7081 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tmpl
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tmpl
>@@ -11,7 +11,7 @@
> 			alert("injecting OLD comment: " +comment);
> 			parent.opener.$('#c p').prev("small").prev("h5").html("Your Edited Comment (preview, pending approval)");
> 			parent.opener.$('#c p').html(comment);
>-			parent.opener.$('#c p').append(" <a href=\"#comment\" onclick=\"Dopop(\'/cgi-bin/koha/opac-review.pl?biblionumber=&amp;reviewid=\');\">Edit<\/a>");
>+			parent.opener.$('#c p').append(" <a href=\"#comment\" onclick=\"Dopop(\'/cgi-bin/koha/opac-review.pl?biblionumber=&amp;reviewid=\');\">Edit<\/a>");
> 			
> 			return 1;
> 		};
>@@ -21,7 +21,7 @@
> 			parent.opener.$('#newcomment').html(
> 				"<h5>Your Comment (preview, pending approval)<\/h5>" +
> 				"<p>"+comment+"<\/p>" +
>-				"<a href=\"#comment\" onclick=\"Dopop(\'/cgi-bin/koha/opac-review.pl?biblionumber=\');\">Edit<\/a><\/p>"
>+				"<a href=\"#comment\" onclick=\"Dopop(\'/cgi-bin/koha/opac-review.pl?biblionumber=\');\">Edit<\/a><\/p>"
> 			);
> 			parent.opener.$("#addcomment").prev("p").remove();
> 			parent.opener.$("#addcomment").remove();
>@@ -66,7 +66,7 @@
> 	</div>
> 
> <form id="reviewf" action="/cgi-bin/koha/opac-review.pl?debug=1" method="post">
>-    <input type="hidden" name="biblionumber" value="" />
>+    <input type="hidden" name="biblionumber" value="" />
> 	<fieldset class="brief">
> 	<legend>Comments on <i> </i>by </legend>
>             <ol><li><textarea id="review" name="review" cols="60" rows="8"></textarea></li></ol>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-serial-issues.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-serial-issues.tmpl
>index 13a3487..aa62bdc 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-serial-issues.tmpl
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-serial-issues.tmpl
>@@ -12,9 +12,9 @@
> <div class="container">
> <h2>Issues for a subscription</h2>
> <div id="views">
>-	<span class="view"><a id="Normalview" href="opac-detail.pl?biblionumber=" class="button">Normal View</a></span>
>+	<span class="view"><a id="Normalview" href="opac-detail.pl?biblionumber=" class="button">Normal View</a></span>
> 		<span class="view"><span id="Briefhistory">Brief history</span></span>
>-	<span class="view"><a id="Fullhistory" href="opac-serial-issues.pl?selectview=full&amp;biblionumber=" class="button">Full History</a></span>
>+	<span class="view"><a id="Fullhistory" href="opac-serial-issues.pl?selectview=full&amp;biblionumber=" class="button">Full History</a></span>
> </div>
> <form method="post" name="f">
> 
>-- 
>1.7.4.1

Actions: View | Diff | Splinter Review

Attachments on bug 6518: 4503 | 4504