Attachment 45043 Details for Bug 15215 – [PASSED QA] Bug 15215: Remove warning due to misuse of UNIVERSAL

[patch] [PASSED QA] Bug 15215: Remove warning due to misuse of UNIVERSAL

PASSED-QA-Bug-15215-Remove-warning-due-to-misuse-o.patch (text/plain), 1.60 KB, created by Katrin Fischer on 2015-11-20 14:00:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-11-20 14:00:26 UTC

Size: 1.60 KB

patch

obsolete

>From c4e127af494ef26f709ee5057f4bd2b9d56bf013 Mon Sep 17 00:00:00 2001
>From: Colin Campbell <colin.campbell@ptfs-europe.com>
>Date: Thu, 19 Nov 2015 12:15:34 +0000
>Subject: [PATCH] [PASSED QA] Bug 15215: Remove warning due to misuse of
> UNIVERSAL
>
>Calling UNIVERSAL's internal methods will cause a depreciation
>warning in perls less that 5.22 as of 5.22 the warning is a fatal
>error causing compilation to abort
>
>Replace the use UNIVERSAL with UNIVERSAL::can to work around the
>buggy construct perldoc UNIVERSAL::can for more info
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>No more worning/error
>No qa errors
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> C4/Installer/PerlDependencies.pm | 5 +++++
> C4/SIP/Sip/MsgType.pm            | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm
>index e815cda..c1d03c7 100644
>--- a/C4/Installer/PerlDependencies.pm
>+++ b/C4/Installer/PerlDependencies.pm
>@@ -777,6 +777,11 @@ our $PERL_DEPS = {
>         'required' => '0',
>         'min_ver'  => '0.28',
>     },
>+    'UNIVERSAL::can' => {
>+        'usage'    => 'SIP',
>+        'required' => '1',
>+        'min_ver'  => '1.10',
>+    },
> };
> 
> 1;
>diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm
>index 3c74377..1e06a19 100644
>--- a/C4/SIP/Sip/MsgType.pm
>+++ b/C4/SIP/Sip/MsgType.pm
>@@ -19,7 +19,7 @@ use Data::Dumper;
> use CGI qw ( -utf8 );
> use C4::Auth qw(&check_api_auth);
> 
>-use UNIVERSAL qw(can);	# make sure this is *after* C4 modules.
>+use UNIVERSAL::can;
> 
> use vars qw(@ISA $VERSION @EXPORT_OK);
> 
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 15215: 44992 | 45037 | 45043