Bugzilla – Attachment 45094 Details for
Bug 15232
Advanced Cataloging Editor: Fix translation issues
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15232: Advanced Cataloging Editor: Fix translation issues
Bug-15232-Advanced-Cataloging-Editor-Fix-translati.patch (text/plain), 2.14 KB, created by
Marc Véron
on 2015-11-23 07:05:36 UTC
(
hide
)
Description:
Bug 15232: Advanced Cataloging Editor: Fix translation issues
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2015-11-23 07:05:36 UTC
Size:
2.14 KB
patch
obsolete
>From 2965033ad97ab1374a843ccbdbfa9a5b3a9f0a7f Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Sat, 21 Nov 2015 01:31:00 +0100 >Subject: [PATCH] Bug 15232: Advanced Cataloging Editor: Fix translation > issues > >This patch makes koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >to comply with Coding guidlines to avoid translation issues: >"JS3: Avoid strings which mix text and markup >Text mustn't contain HTML tags." > >To test: >- Apply patch >- Verify that code changes are correct (html markup moved out of > function _(...) ) >- Bonus test: Enable syspref 'EnableAdvancedCatalogingEditor' and verify that > it works as before >--- > koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >index 443c022..c0bb4dc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >@@ -559,7 +559,7 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr > invalidateSearchResults(); > Search.Reconnect(); > } else { >- humanMsg.displayMsg( _("<h3>Internal search error</h3>") + '<p>' + error + '</p>' + _("<p>Please <b>refresh</b> the page and try again."), { className: 'humanError' } ); >+ humanMsg.displayMsg( 'h3' + _("Internal search error") + '</h3><p>' + error + '</p><p>' + _("Please refresh the page and try again.") + '</p>', { className: 'humanError' } ); > } > } > >@@ -948,7 +948,7 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr > errors.push(error); > } ); > >- humanMsg.displayMsg( _("<h3>Failed to run macro:</h3>") + '<ul><li>' + errors.join('</li><li>') + '</li></ul>', { className: 'humanError' } ); >+ humanMsg.displayMsg( 'h3' + _("Failed to run macro:") + '</h3><ul><li>' + errors.join('</li><li>') + '</li></ul>', { className: 'humanError' } ); > > return false; > } ); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15232
:
45094
|
45110
|
45129
|
45143
|
46040