Attachment 45146 Details for Bug 14599 – Bug 14599 - Saved auth login and password are used in patron creation from

[patch] Bug 14599 - Saved auth login and password are used in patron creation from

Bug-14599---Saved-auth-login-and-password-are-used.patch (text/plain), 2.00 KB, created by Jonathan Druart on 2015-11-25 15:46:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-11-25 15:46:23 UTC

Size: 2.00 KB

patch

obsolete

>From 9441551adcfbcfd7acbdacd23cfa3055dc568012 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Mon, 23 Nov 2015 09:19:06 +0100
>Subject: [PATCH] Bug 14599 - Saved auth login and password are used in patron
> creation from
>
>If one save the login and password used to authenticate in staff interface, when creating a new patron, those login and password are filled in the corresponding inputs in the form.
>This behaviour is awkward from web browser.
>
>A trick is provided by http://stackoverflow.com/questions/10738090/why-firefox-autocomplete-even-with-different-input-name
>
>I found that the best way is to use an hidden disabled input between userid and password.
>
>Test plan :
>
>- Log into Koha
>- Allow the browser to save the userid/password
>- Be sure that you have only one userid/password for this Koha
>- Loggout
>- Re log to check the browser autocomplets the authentication form
>- Create a new patron
>=> Without patch your saved userid/password have been added to the form
>=> With patch your saved userid/password have not been added to the form
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>This is not elegant but it works.
>Note that the problem does not exist with Chromium
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index a3b7a9d..28a102d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -813,6 +813,9 @@
> 	[% END %]
> [% END %]
> 
>+[%# Dummy input to avoid Firefox from using userid/password saved for authentication %]
>+<input type="text" disabled="disabled" style="display:none" />
>+
> 	  [% IF ( mandatoryuserid ) %]<span class="required">Required</span>[% END %]
> 		</li>
>         [%END %]
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 14599: 45099 | 45125 | 45146