Attachment 45170 Details for Bug 15256 – Bug 15256: Fix items table display on the detail page

[patch] Bug 15256: Fix items table display on the detail page

Bug-15256-Fix-items-table-display-on-the-detail-pa.patch (text/plain), 2.25 KB, created by Jonathan Druart on 2015-11-25 17:11:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-11-25 17:11:41 UTC

Size: 2.25 KB

patch

obsolete

>From 6660b710a22a2c7cf998a72939857848f243b0f6 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 25 Nov 2015 17:08:43 +0000
>Subject: [PATCH] Bug 15256: Fix items table display on the detail page
>
>Bug 14966 fixed a bug but introduced another one:
>With IndependentBranches set to 'prevent', if the librarian (without the
>superlibrarian permission) can edit items but not all, the table is
>broken.
>DataTables raises the following warning:
>"DataTables warning: table id=DataTables_Table_1 - Requested unknown
>parameter '8' for row0."
>
>And does not display correctly.
>
>Test plan:
>1/ Create a biblio record with 1+ items located in different places.
>2/ Create/use a patron with the permission to edit items
>3/ Set the IndependentBranches pref to 'prevent'
>4/ With this patron logged in, go on the record detail page.
>Without this patch, the display is broken (only 1 edit link and 1 td
>missing, DataTables raises a warning).
>With this patch, the display is correct.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index f9a1d35..f2fb6e2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -807,8 +807,12 @@ function verify_images() {
>                        [% END %]
>                     </td>
>                 [% END %]
>-                [% IF CAN_user_editcatalogue_edit_items and not item.cannot_be_edited %]
>-                    <td><a href="/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=[% item.biblionumber %]&itemnumber=[% item.itemnumber %]#edititem">Edit</a></td>
>+                [% IF CAN_user_editcatalogue_edit_items %]
>+                    <td>
>+                        [% UNLESS item.cannot_be_edited %]
>+                            <a href="/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=[% item.biblionumber %]&itemnumber=[% item.itemnumber %]#edititem">Edit</a>
>+                        [% END %]
>+                    </td>
>                 [% END %]
>                 </tr>
>             [% END %]
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 15256: 45170 | 45206 | 45207