Bugzilla – Attachment 45182 Details for
Bug 11358
Use Amazon's HTTPS URLs for covers when using HTTPS in Koha.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug: 11358 - Use HTTPS Amazon images everywhere
Bug-11358---Use-HTTPS-Amazon-images-everywhere.patch (text/plain), 20.88 KB, created by
Charles Farmer
on 2015-11-26 17:32:44 UTC
(
hide
)
Description:
Bug: 11358 - Use HTTPS Amazon images everywhere
Filename:
MIME Type:
Creator:
Charles Farmer
Created:
2015-11-26 17:32:44 UTC
Size:
20.88 KB
patch
obsolete
>From f68f47952c5fe79d83ca048eb83f7b8f15c10585 Mon Sep 17 00:00:00 2001 >From: Charles Farmer <charles.farmer@inlibro.com> >Date: Thu, 26 Nov 2015 12:25:38 -0500 >Subject: [PATCH] Bug: 11358 - Use HTTPS Amazon images everywhere > >Tried to solve the conflicts. Additionnaly, edited files that were still using "http://images.amazon.com". Please test thoroughly. > >Using HTTPS on an HTTP page shouldn't trigger security issues. I pruned some templates to use HTTPS whenever we're fetching an image from Amazon instead of switching on the using_https variable. >--- > .../intranet-tmpl/prog/en/css/staff-global.css | 11 +++++++++ > .../prog/en/includes/doc-head-close.inc | 9 ++++++++ > koha-tmpl/intranet-tmpl/prog/en/js/amazonimages.js | 15 +++++++++++++ > .../prog/en/modules/catalogue/detail.tt | 26 +++++++++++----------- > .../bootstrap/en/includes/shelfbrowser.inc | 2 +- > .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +---- > .../bootstrap/en/modules/opac-opensearch.tt | 7 +++++- > .../bootstrap/en/modules/opac-results-grouped.tt | 2 +- > .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 4 ---- > .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- > .../bootstrap/en/modules/opac-showreviews-rss.tt | 2 +- > .../bootstrap/en/modules/opac-showreviews.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/js/amazonimages.js | 13 ++++++----- > 13 files changed, 67 insertions(+), 34 deletions(-) > create mode 100644 koha-tmpl/intranet-tmpl/prog/en/js/amazonimages.js > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >index 0188019..8dd2470 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >@@ -2292,6 +2292,17 @@ div.authorizedheading { > display: inline; > } > >+span.no-image { >+ background-color : #FFF; >+ border: 1px solid #979797; >+ color : #AAA; >+ display:block; >+ font-size : 86%; >+ font-weight : bold; >+ text-align : center; >+ width : 75px; >+} >+ > #hierarchies a { > font-weight: normal; > text-decoration: underline; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc >index 73514c2..d5efe92 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc >@@ -86,5 +86,14 @@ > </script> > [% END %] > >+[% IF ( AmazonCoverImages ) %] >+ <script type="text/javascript" language="javascript"> >+ //<![CDATA[ >+ var NO_AMAZON_IMAGE = _("No cover image available"); >+ //]]> >+ </script> >+ <script type="text/javascript" language="javascript" src="[% themelang %]/js/amazonimages.js"></script> >+[% END %] >+ > <!-- For keeping the text when navigating the search tabs --> > [% INCLUDE 'searchbox-keep-text.inc' %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/amazonimages.js b/koha-tmpl/intranet-tmpl/prog/en/js/amazonimages.js >new file mode 100644 >index 0000000..2184b24 >--- /dev/null >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/amazonimages.js >@@ -0,0 +1,15 @@ >+// http://www.oreillynet.com/pub/a/javascript/2003/10/21/amazonhacks.html >+function verify_images() { >+ $("img").each(function(i){ >+ if ((this.src.indexOf('images.amazon.com') >= 0) || (this.src.indexOf('g-images.amazon.com') >=0) >+ || (this.src.indexOf('syndetics.com') >=0) || (this.src.indexOf('images-na.ssl-images-amazon.com') >= 0)) { >+ w = this.width; >+ h = this.height; >+ if ((w == 1) || (h == 1)) { >+ $(this).parent().html("<span class=\"no-image\">"+NO_AMAZON_IMAGE+"</span>"); >+ } else if ((this.complete != null) && (!this.complete)) { >+ $(this).parent().html("<span class=\"no-image\">"+NO_AMAZON_IMAGE+"</span>"); >+ } >+ } >+ }); >+} >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index f9a1d35..2cc7785 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -46,13 +46,14 @@ function verify_images() { > if( $(this).find('img').length < 1 ) $(this).remove(); > }); > $("#editions img").each(function(i){ >- if ((this.src.indexOf('images.amazon.com') >= 0) || (this.src.indexOf('g-images.amazon.com') >=0) || (this.src.indexOf('images-na.ssl-images-amazon.com'))) { >+ if ((this.src.indexOf('images.amazon.com') >= 0) || (this.src.indexOf('g-images.amazon.com') >=0) >+ || (this.src.indexOf('images-na.ssl-images-amazon.com') >= 0)) { > w = this.width; > h = this.height; > if ((w == 1) || (h == 1)) { >- this.src = 'https://images-na.ssl-images-amazon.com/images/G/01/x-site/icons/no-img-sm.gif'; >+ $(this).parent().html("<span class=\"no-image\">"+NO_AMAZON_IMAGE+"</span>"); > } else if ((this.complete != null) && (!this.complete)) { >- this.src = 'https://images-na.ssl-images-amazon.com/images/G/01/x-site/icons/no-img-sm.gif'; >+ $(this).parent().html("<span class=\"no-image\">"+NO_AMAZON_IMAGE+"</span>"); > } > } > }); >@@ -388,11 +389,7 @@ function verify_images() { > [% IF ( AmazonCoverImages ) %] > <div id="amazon-bookcoverimg"> > <a href="http://www.amazon[% AmazonTld %]/gp/reader/[% normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link"> >- [% IF ( using_https ) %] >- <img border="0" src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /> >- [% ELSE %] >- <img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /> >- [% END %] >+ <img border="0" src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /> > </a></div> > [% END %] > [% END %] >@@ -466,11 +463,7 @@ function verify_images() { > [% IF ( AmazonCoverImages ) %] > <div id="amazon-bookcoverimg"> > <a href="http://www.amazon[% AmazonTld %]/gp/reader/[% normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link"> >- [% IF ( using_https ) %] > <img border="0" src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /> >- [% ELSE %] >- <img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /> >- [% END %] > </a> > </div> > [% END %] >@@ -991,7 +984,14 @@ function verify_images() { > [% IF ( FRBRizeEditions ) %][% IF ( XISBNS ) %] > <div id="editions"><h4>Editions</h4> > <table> >-[% FOREACH XISBN IN XISBNS %]<tr>[% IF ( AmazonCoverImages ) %]<td><a href="http://www.amazon.com/gp/reader/[% XISBN.normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link"><img src="https://images-na.ssl-images-amazon.com/images/P/[% XISBN.normalized_isbn %].01._AA75_PU_PU-5_.jpg" /></a></td>[% END %] >+[% FOREACH XISBN IN XISBNS %] >+<tr> >+ [% IF ( AmazonCoverImages ) %] >+ <td> >+ <a href="http://www.amazon.com/gp/reader/[% XISBN.normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link"> >+ <img src="https://images-na.ssl-images-amazon.com/images/P/[% XISBN.normalized_isbn %].01._AA75_PU_PU-5_.jpg" /></a> >+ </td> >+ [% END %] > [% UNLESS ( item_level_itypes ) %]<td>[% IF ( noItemTypeImages ) %][% XISBN.description %][% ELSE %]<img src="[% XISBN.imageurl %]" alt="[% XISBN.description %]" title="[% XISBN.description %]">[% END %]</td>[% END %] > <td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% XISBN.biblionumber %]">[% XISBN.title |html %]</a> by [% XISBN.author %] ©[% XISBN.copyrightdate %] > [% IF ( XISBN.publishercode ) %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >index 8c3fcd9..f806b4f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >@@ -26,7 +26,7 @@ > [% END %] > [% IF ( OPACAmazonCoverImages ) %] > [% IF ( item.browser_normalized_isbn ) %] >- <img src="http://images.amazon.com/images/P/[% item.browser_normalized_isbn %].01._AA75_PU_PU-5_.jpg" alt="" /> >+ <img src="https://images-na.ssl-images-amazon.com/images/P/[% item.browser_normalized_isbn %].01._AA75_PU_PU-5_.jpg" alt="" /> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 951029a..fd4ea9f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -58,11 +58,7 @@ > [% ELSE %] > <a href="http://www.amazon[% AmazonTld %]/dp/[% normalized_isbn %]"> > [% END %] >- [% IF ( using_https ) %] > <img border="0" src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="Cover image" /></a> >- [% ELSE %] >- <img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="Cover image" /></a> >- [% END %] > [% END %] > > [% IF ( SyndeticsEnabled && SyndeticsCoverImages ) %] >@@ -964,7 +960,7 @@ > <tr> > <td> > [% IF ( OPACAmazonCoverImages ) %] >- <img src="http://images.amazon.com/images/P/[% XISBN.normalized_isbn %].01._AA75_PU_PU-5_.jpg" alt="" /> >+ <img src="https://images-na.ssl-images-amazon.com/images/P/[% XISBN.normalized_isbn %].01._AA75_PU_PU-5_.jpg" alt="" /> > [% END %] > > [% IF ( SyndeticsEnabled && SyndeticsCoverImages ) %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt >index e1a9efe..748f0f3 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt >@@ -37,7 +37,12 @@ > <dc:identifier>ISBN [% SEARCH_RESULT.isbn |html %]</dc:identifier> > <link>[% IF ( SEARCH_RESULT.BiblioDefaultViewmarc ) %][% OPACBaseURL %]/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=[% SEARCH_RESULT.biblionumber %][% ELSE %][% IF ( SEARCH_RESULT.BiblioDefaultViewisbd ) %][% OPACBaseURL %]/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=[% SEARCH_RESULT.biblionumber %][% ELSE %][% OPACBaseURL %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% SEARCH_RESULT.biblionumber %][% END %][% END %]</link> > <description><![CDATA[ >-[% IF ( OPACAmazonCoverImages ) %][% IF ( SEARCH_RESULT.normalized_isbn ) %]<img src="http://images.amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" />[% END %][% END %] >+[% IF ( OPACAmazonCoverImages ) %] >+ [% IF ( SEARCH_RESULT.normalized_isbn ) %] >+ <img src="https://images-na.ssl-images-amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" /> >+ [% END %] >+[% END %] >+ > [% IF ( SyndeticsEnabled ) %][% IF ( SyndeticsCoverImages ) %][% IF ( SEARCH_RESULT.content_identifier_exists ) %]<img src="http://www.syndetics.com/index.aspx?isbn=[% SEARCH_RESULT.normalized_isbn %]/SC.GIF&client=[% SEARCH_RESULT.SyndeticsClientCode %]&type=xw10[% IF ( SEARCH_RESULT.normalized_upc ) %]&upc=[% SEARCH_RESULT.normalized_upc %][% END %][% IF ( SEARCH_RESULT.normalized_oclc ) %]&oclc=[% SEARCH_RESULT.normalized_oclc %][% END %]" alt="" /> > [% ELSE %] > <img src="http://www.syndetics.com/index.aspx?isbn=[% SEARCH_RESULT.normalized_isbn %]/SC.GIF&client=[% SyndeticsClientCode %]&type=xw10&upc=[% SEARCH_RESULT.normalized_upc %]&oclc=[% SEARCH_RESULT.normalized_oclc %]" alt="" /> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt >index 68c543c..b36dacb 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt >@@ -157,7 +157,7 @@ href="/cgi-bin/koha/opac-rss.pl?[% query_cgi %][% limit_cgi |html %]" /> > [% END %] > <td> > [% IF ( OPACAmazonCoverImages ) %] >- <a class="p1" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% GROUP_RESULT.biblionumber |url %]">[% IF ( GROUP_RESULT.isbn ) %]<img src="http://images.amazon.com/images/P/[% GROUP_RESULT.isbn %].01.TZZZZZZZ.jpg" alt="" class="thumbnail" />[% ELSE %]<img src="http://g-images.amazon.com/images/G/01/x-site/icons/no-img-sm.gif" alt="" class="thumbnail" />[% END %] >+ <a class="p1" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% GROUP_RESULT.biblionumber |url %]">[% IF ( GROUP_RESULT.isbn ) %]<img src="https://images-na.ssl-images-amazon.com/images/P/[% GROUP_RESULT.isbn %].01.TZZZZZZZ.jpg" alt="" class="thumbnail" />[% ELSE %]<img src="http://g-images.amazon.com/images/G/01/x-site/icons/no-img-sm.gif" alt="" class="thumbnail" />[% END %] > </a> > [% ELSE %] > [% UNLESS ( noItemTypeImages ) %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 8a0ec89..f2c3d7d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -240,11 +240,7 @@ > [% END %] > [% IF ( OPACAmazonCoverImages ) %] > [% IF ( SEARCH_RESULT.normalized_isbn ) %] >- [% IF ( using_https ) %] > <span title="[% SEARCH_RESULT.biblionumber %]" id="amazon-thumbnail[% loop.count %]"><img src="https://images-na.ssl-images-amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" class="item-thumbnail" /></span> >- [% ELSE %] >- <span title="[% SEARCH_RESULT.biblionumber %]" id="amazon-thumbnail[% loop.count %]"><img src="http://images.amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" class="item-thumbnail" /></span> >- [% END %] > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index 3c96dde..d8866c6 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -305,7 +305,7 @@ > > [% IF ( OPACAmazonCoverImages ) %] > [% IF ( itemsloo.normalized_isbn ) %] >- <span title="[% SEARCH_RESULT.biblionumber %]" id="amazon-thumbnail[% loop.count %]"><img src="http://images.amazon.com/images/P/[% itemsloo.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" /></span> >+ <span title="[% SEARCH_RESULT.biblionumber %]" id="amazon-thumbnail[% loop.count %]"><img src="https://images-na.ssl-images-amazon.com/images/P/[% itemsloo.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" /></span> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt >index c6d858d..fddf531 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt >@@ -11,7 +11,7 @@ > <title>New comment on [% review.title |html %] [% FOREACH subtitl IN review.subtitle %], [% subtitl.subfield |html %][% END %]</title> > <link>[% OPACBaseURL %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% review.biblionumber %]#comments</link> > <description><![CDATA[ >-[% IF ( OPACAmazonCoverImages ) %][% IF ( review.normalized_isbn ) %]<img src="http://images.amazon.com/images/P/[% review.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" />[% END %][% END %] >+[% IF ( OPACAmazonCoverImages ) %][% IF ( review.normalized_isbn ) %]<img src="https://images-na.ssl-images-amazon.com/images/P/[% review.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" />[% END %][% END %] > > [% IF ( SyndeticsEnabled ) %][% IF ( SyndeticsCoverImages ) %][% IF ( review.content_identifier_exists ) %][% IF ( using_https ) %]<img src="https://secure.syndetics.com/index.aspx?isbn=[% review.normalized_isbn %]/SC.GIF&client=[% SyndeticsClientCode %]&type=xw10&upc=[% review.normalized_upc %]&oclc=[% review.normalized_oclc %]" alt="" /> > [% ELSE %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt >index 687a671..464aa21 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt >@@ -115,7 +115,7 @@ > > [% IF ( OPACAmazonCoverImages ) %] > [% IF ( review.normalized_isbn ) %] >- <img src="http://images.amazon.com/images/P/[% review.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" class="thumbnail" /> >+ <img src="https://images-na.ssl-images-amazon.com/images/P/[% review.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" class="thumbnail" /> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/amazonimages.js b/koha-tmpl/opac-tmpl/bootstrap/js/amazonimages.js >index f7b4887..2184b24 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/js/amazonimages.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/js/amazonimages.js >@@ -1,14 +1,15 @@ > // http://www.oreillynet.com/pub/a/javascript/2003/10/21/amazonhacks.html > function verify_images() { >- $("img").each(function(i){ >- if ((this.src.indexOf('images.amazon.com') >= 0) || (this.src.indexOf('g-images.amazon.com') >=0) || (this.src.indexOf('syndetics.com') >=0) ) { >+ $("img").each(function(i){ >+ if ((this.src.indexOf('images.amazon.com') >= 0) || (this.src.indexOf('g-images.amazon.com') >=0) >+ || (this.src.indexOf('syndetics.com') >=0) || (this.src.indexOf('images-na.ssl-images-amazon.com') >= 0)) { > w = this.width; > h = this.height; > if ((w == 1) || (h == 1)) { >- $(this).parent().html("<span class=\"no-image\">"+NO_AMAZON_IMAGE+"</span>"); >+ $(this).parent().html("<span class=\"no-image\">"+NO_AMAZON_IMAGE+"</span>"); > } else if ((this.complete != null) && (!this.complete)) { >- $(this).parent().html("<span class=\"no-image\">"+NO_AMAZON_IMAGE+"</span>"); >+ $(this).parent().html("<span class=\"no-image\">"+NO_AMAZON_IMAGE+"</span>"); > } > } >- }); >- } >+ }); >+} >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11358
:
23361
|
35264
| 45182