Attachment 45207 Details for Bug 15256 – [PASSED QA] Bug 15256: Fix items table display on the detail page

[patch] [PASSED QA] Bug 15256: Fix items table display on the detail page

PASSED-QA-Bug-15256-Fix-items-table-display-on-the.patch (text/plain), 2.52 KB, created by Katrin Fischer on 2015-11-26 23:12:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-11-26 23:12:23 UTC

Size: 2.52 KB

patch

obsolete

>From de2793568043bf449d1c3781cf8c5747640a5e86 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 25 Nov 2015 17:08:43 +0000
>Subject: [PATCH] [PASSED QA] Bug 15256: Fix items table display on the detail
> page
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Bug 14966 fixed a bug but introduced another one: With
>IndependentBranches set to 'prevent', if the librarian (without the
>superlibrarian permission) can edit items but not all, the table is
>broken.  DataTables raises the following warning: "DataTables warning:
>table id=DataTables_Table_1 - Requested unknown parameter '8' for row0."
>And does not display correctly.
>
>Test plan:
>1/ Create a biblio record with 1+ items located in different places.
>2/ Create/use a patron with the permission to edit items
>3/ Set the IndependentBranches pref to 'prevent'
>4/ With this patron logged in, go on the record detail page.
>Without this patch, the display is broken (only 1 edit link and 1 td
>missing, DataTables raises a warning).
>With this patch, the display is correct.
>
>Signed-off-by: FrÃ©dÃ©ric Demians <f.demians@tamil.fr>
>  See the warning, and the broken table. Solved by this patch.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index f9a1d35..f2fb6e2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -807,8 +807,12 @@ function verify_images() {
>                        [% END %]
>                     </td>
>                 [% END %]
>-                [% IF CAN_user_editcatalogue_edit_items and not item.cannot_be_edited %]
>-                    <td><a href="/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=[% item.biblionumber %]&itemnumber=[% item.itemnumber %]#edititem">Edit</a></td>
>+                [% IF CAN_user_editcatalogue_edit_items %]
>+                    <td>
>+                        [% UNLESS item.cannot_be_edited %]
>+                            <a href="/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=[% item.biblionumber %]&itemnumber=[% item.itemnumber %]#edititem">Edit</a>
>+                        [% END %]
>+                    </td>
>                 [% END %]
>                 </tr>
>             [% END %]
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 15256: 45170 | 45206 | 45207