Attachment 45266 Details for Bug 9184 – Bug 9184: Acq - Don't show authority batches when ordering from staged file

[patch] Bug 9184: Acq - Don't show authority batches when ordering from staged file

Bug-9184-Acq---Dont-show-authority-batches-when-or.patch (text/plain), 1.58 KB, created by Jonathan Druart on 2015-12-01 14:20:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-12-01 14:20:29 UTC

Size: 1.58 KB

patch

obsolete

>From 58af94d83793a589cd99edc966ef136730916e95 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Sun, 22 Nov 2015 01:18:04 +0100
>Subject: [PATCH] Bug 9184: Acq - Don't show authority batches when ordering
> from staged file
>
>When ordering from a staged file, the list of files
>should only include imports of bilbiographic and
>no authority data.
>
>To test - start without the patch:
>1) Stage an authority file
>2) Stage a bilbiographic file
>3) Create a new basked in acquisitions
>4) Create a new order line selecting "From a staged file"
>5) Verify that both files are shown
>6) Apply patch
>7) Verify that only the bibliographc file shows
>   in the list now
>
>Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
>Works as advertised
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> acqui/addorderiso2709.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl
>index 6bb744f..8ce2ce1 100755
>--- a/acqui/addorderiso2709.pl
>+++ b/acqui/addorderiso2709.pl
>@@ -338,7 +338,7 @@ sub import_batches_list {
> 
>     my @list = ();
>     foreach my $batch (@$batches) {
>-        if ( $batch->{'import_status'} =~ /^staged$|^reverted$/ ) {
>+        if ( $batch->{'import_status'} =~ /^staged$|^reverted$/ && $batch->{'record_type'} eq 'biblio') {
>             # check if there is at least 1 line still staged
>             my $stagedList=GetImportRecordsRange($batch->{'import_batch_id'}, undef, 1, $batch->{import_status}, { order_by_direction => 'ASC' });
>             if (scalar @$stagedList) {
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 9184: 45073 | 45074 | 45176 | 45266