Bugzilla – Attachment 45305 Details for
Bug 14636
Sorting and searching by publication year in item search doesn't work correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14636: Item search - improving display
Bug-14636-Item-search---improving-display.patch (text/plain), 2.98 KB, created by
Fridolin Somers
on 2015-12-02 08:07:43 UTC
(
hide
)
Description:
Bug 14636: Item search - improving display
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2015-12-02 08:07:43 UTC
Size:
2.98 KB
patch
obsolete
>From 95f2c51fd26e335c74cc597154cf6f6995d0938a Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Sat, 21 Nov 2015 22:37:03 +0100 >Subject: [PATCH] Bug 14636: Item search - improving display > >- Changes "Publication Date" to "Publication date" > in the CSV export >- Fixes 'no JavaScript fallback' display to match > the normal display > - only show 'by' when it's UNIMARC and an author > exist > - show copyrightdate if publicationyear is empty > >To test: >- Turn of Javascript in your browser before you > item search. This will activate the alternative > display. >- For MARC21: > - Verify that the author displays when existing > and no 'by' is shown. > - Verify that the publication date is now shown. >- For UNIMARC: > - Verify that 'by' only displays when there is > an author to display. > - Verify that the publication date is still > shown. >- Try the CSV export. >- Verify that the CSV header now reads 'Publication date'. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Successfully tested non-JS behavior and CSV export. DID NOT test >UNIMARC. > >Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> >--- > .../intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.inc | 5 +++-- > .../prog/en/includes/csv_headers/catalogue/itemsearch.tt | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.inc >index 5b08b91..8f65913 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.inc >@@ -1,12 +1,13 @@ > [%- USE Branches -%] >+[%- USE Koha -%] > [% biblio = item.biblio %] > [% biblioitem = item.biblioitem %] > <tr> > <td> > <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblio.biblionumber %]" title="Go to record detail page">[% biblio.title %]</a> >- by [% biblio.author %] >+ [% IF ( Koha.Preference( 'marcflavour' ) == 'UNIMARC' && biblio.author ) %] by[% END %] [% biblio.author |html %] > </td> >- <td>[% biblioitem.publicationyear %]</td> >+ <td>[% biblioitem.publicationyear || biblio.copyrightdate %]</td> > <td>[% biblioitem.publishercode %]</td> > <td>[% biblioitem.collectiontitle %]</td> > <td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/catalogue/itemsearch.tt >index 28fabe7..bac4b14 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/catalogue/itemsearch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/catalogue/itemsearch.tt >@@ -1 +1 @@ >-Title, Publication Date, Publisher, Collection, Barcode, Call number, Home library, Current location, Shelving location, Inventory number, Status, Checkouts >+Title, Publication date, Publisher, Collection, Barcode, Call number, Home library, Current location, Shelving location, Inventory number, Status, Checkouts >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14636
:
45070
|
45071
|
45120
|
45121
|
45153
|
45161
|
45168
|
45169
|
45304
|
45305
|
45306
|
45307
|
45315
|
45316
|
45317
|
45318
|
45319