Bugzilla – Attachment 4535 Details for
Bug 5878
overdue printing fixes and improvements
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
follow-up fixing perl warnings
0001-follow-up-of-rebased-patch-fixing-Perl-warnings.patch (text/plain), 1.68 KB, created by
Paul Poulain
on 2011-06-29 20:39:31 UTC
(
hide
)
Description:
follow-up fixing perl warnings
Filename:
MIME Type:
Creator:
Paul Poulain
Created:
2011-06-29 20:39:31 UTC
Size:
1.68 KB
patch
obsolete
>From 6da1798de099a77281752f21d191a0a5c1938f41 Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Wed, 29 Jun 2011 22:37:38 +0200 >Subject: [PATCH] follow-up of rebased patch : fixing Perl warnings > >--- > misc/cronjobs/overdue_notices.pl | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) > >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index 40d83f5..8353194 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -281,14 +281,15 @@ GetOptions( > pod2usage(1) if $help; > pod2usage( -verbose => 2 ) if $man; > >-my $columns_def_hashref = C4::Reports::Guided::_get_column_defs(); >+my $cgi = new CGI; # this CGI is useless, except to avoid an error >+my $columns_def_hashref = C4::Reports::Guided::_get_column_defs($cgi); > > foreach my $key ( keys %$columns_def_hashref ) { > my $initkey = $key; > $key =~ s/[^\.]*\.//; > $columns_def_hashref->{$key} = $columns_def_hashref->{$initkey}; > } >-print Dump($columns_def_hashref); >+ > if ( defined $csvfilename && $csvfilename =~ /^-/ ) { > warn qq(using "$csvfilename" as filename, that seems odd); > } >@@ -698,7 +699,7 @@ sub parse_letter { # FIXME: this code should probably be moved to C4::Letters:pa > PROCESS_ITEMS: > while (scalar(@{$params->{'items'}}) > 0) { > my $item = shift @{$params->{'items'}}; >- my $fine = GetFine($item->{'itemnumber'}, $params->{'borrowernumber'}); >+ my $fine = GetFine($item->{'itemnumber'}, $params->{'borrowernumber'})||0; > if (!$item_format) { > $params->{'letter'}->{'content'} =~ m/(<item>.*<\/item>)/; > $item_format = $1; >-- >1.7.4.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5878
:
3316
|
4533
| 4535 |
4601
|
4974