Bugzilla – Attachment 45431 Details for
Bug 15244
t/db_dependent/Reserves.t depends on external data/configuration
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15244: t/db_dependent/Reserves.t depends on external data/configuration
Bug-15244-tdbdependentReservest-depends-on-externa.patch (text/plain), 1.49 KB, created by
Galen Charlton
on 2015-12-05 16:11:08 UTC
(
hide
)
Description:
Bug 15244: t/db_dependent/Reserves.t depends on external data/configuration
Filename:
MIME Type:
Creator:
Galen Charlton
Created:
2015-12-05 16:11:08 UTC
Size:
1.49 KB
patch
obsolete
>From 05f100cc9e53f25cc0d972f0ae9cf152d111aabd Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Tue, 1 Dec 2015 20:22:27 +0100 >Subject: [PATCH] Bug 15244: t/db_dependent/Reserves.t depends on external > data/configuration > >Test 14 in t/db_dependent/Reserves.t fails if syspref LocalHoldsPriority is >set to "[Give] priority for filling holds to patrons whose... > >To verify: >- Set syspref as above and run test. Test 14 fails. >- Set syspref to [Don't give] and run test agein, it passes OK. > >To test: >- Apply patch >- Run test again with syspref set / not set >Expected result: In both cases test should pass > >(AMended to change bug title) > >Signed-off-by: Galen Charlton <gmcharlt@gmail.com> >--- > t/db_dependent/Reserves.t | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t >index 7301757..8a6ab1c 100755 >--- a/t/db_dependent/Reserves.t >+++ b/t/db_dependent/Reserves.t >@@ -280,6 +280,10 @@ is( $messages->{ResFound}->{borrowernumber}, > # Return the FPL item at FPL. The hold that should be triggered is > # the one placed by the RPL patron, as that patron is first in line > # and RPL imposes no restrictions on whose holds its items can fill. >+ >+# Ensure that the preference 'LocalHoldsPriority' is not set (Bug 15244): >+C4::Context->set_preference( 'LocalHoldsPriority', '' ); >+ > (undef, $messages, undef, undef) = AddReturn('bug10272_FPL', 'FPL'); > is( $messages->{ResFound}->{borrowernumber}, > $requesters{'RPL'}, >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15244
:
45286
|
45287
|
45291
|
45431
|
45437