Attachment 45437 Details for Bug 15244 – [PASSED QA] Bug 15244: t/db_dependent/Reserves.t depends on external data/configuration

[patch] [PASSED QA] Bug 15244: t/db_dependent/Reserves.t depends on external data/configuration

PASSED-QA-Bug-15244-tdbdependentReservest-depends-.patch (text/plain), 1.55 KB, created by Katrin Fischer on 2015-12-06 21:26:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-12-06 21:26:08 UTC

Size: 1.55 KB

patch

obsolete

>From 17cc07f8d8f944f436de7ef02a9ce016f8a99862 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Tue, 1 Dec 2015 20:22:27 +0100
>Subject: [PATCH] [PASSED QA] Bug 15244: t/db_dependent/Reserves.t depends on
> external data/configuration
>
>Test 14 in t/db_dependent/Reserves.t fails if syspref LocalHoldsPriority is
>set to "[Give] priority for filling holds to patrons whose...
>
>To verify:
>- Set syspref as above and run test. Test 14 fails.
>- Set syspref to [Don't give] and run test agein, it passes OK.
>
>To test:
>- Apply patch
>- Run test again with syspref set / not set
>Expected result: In both cases test should pass
>
>(AMended to change bug title)
>
>Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> t/db_dependent/Reserves.t | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t
>index 7301757..8a6ab1c 100755
>--- a/t/db_dependent/Reserves.t
>+++ b/t/db_dependent/Reserves.t
>@@ -280,6 +280,10 @@ is( $messages->{ResFound}->{borrowernumber},
> # Return the FPL item at FPL.  The hold that should be triggered is
> # the one placed by the RPL patron, as that patron is first in line
> # and RPL imposes no restrictions on whose holds its items can fill.
>+
>+# Ensure that the preference 'LocalHoldsPriority' is not set (Bug 15244):
>+C4::Context->set_preference( 'LocalHoldsPriority', '' );
>+
> (undef, $messages, undef, undef) = AddReturn('bug10272_FPL', 'FPL');
> is( $messages->{ResFound}->{borrowernumber},
>     $requesters{'RPL'},
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 15244: 45286 | 45287 | 45291 | 45431 | 45437