Attachment 45459 Details for Bug 15325 – Bug 15325: Fix --table option of rebuild_zebra.pl

[patch] Bug 15325: Fix --table option of rebuild_zebra.pl

Bug-15325-Fix---table-option-of-rebuildzebrapl.patch (text/plain), 1.42 KB, created by Frédéric Demians on 2015-12-07 16:07:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Frédéric Demians

Created: 2015-12-07 16:07:31 UTC

Size: 1.42 KB

patch

obsolete

>From b12fe84246e7434cc36932b412e7707ce50b7831 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Mon, 7 Dec 2015 15:25:25 +0100
>Subject: [PATCH] Bug 15325: Fix --table option of rebuild_zebra.pl
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Option's value given on command line was never used and 'biblioitems'
>was used instead.
>
>Test plan:
>1. git checkout master
>2. perl misc/migration_tools/rebuild_zebra.pl -b -t items --where "price = 42"
>3. You should see errors printed on screen about an unknown column
>4. Apply patch
>5. perl misc/migration_tools/rebuild_zebra.pl -b -t items --where "price = 42"
>6. No errors \o/
>
>Signed-off-by: FrÃ©dÃ©ric Demians <f.demians@tamil.fr>
>---
> misc/migration_tools/rebuild_zebra.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/misc/migration_tools/rebuild_zebra.pl b/misc/migration_tools/rebuild_zebra.pl
>index dd97170..beaf4d3 100755
>--- a/misc/migration_tools/rebuild_zebra.pl
>+++ b/misc/migration_tools/rebuild_zebra.pl
>@@ -452,7 +452,7 @@ sub select_all_authorities {
> 
> sub select_all_biblios {
>     $table = 'biblioitems'
>-      if grep { /^$table$/ } @tables_allowed_for_select;
>+      unless grep { /^$table$/ } @tables_allowed_for_select;
>     my $strsth = qq{ SELECT biblionumber FROM $table };
>     $strsth.=qq{ WHERE $where } if ($where);
>     $strsth.=qq{ LIMIT $length } if ($length && !$offset);
>-- 
>2.6.2

Actions: View | Diff | Splinter Review

Attachments on bug 15325: 45448 | 45459 | 45497