Attachment 45550 Details for Bug 12772 – Bug 12772 - Renames atomic update file, .pl -> .perl

[patch] Bug 12772 - Renames atomic update file, .pl -> .perl

Bug-12772---Renames-atomic-update-file-pl---perl.patch (text/plain), 6.83 KB, created by Eivin Giske Skaaren on 2015-12-09 17:07:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Eivin Giske Skaaren

Created: 2015-12-09 17:07:58 UTC

Size: 6.83 KB

patch

obsolete

>From ad4d7a201a95ac0138705eb02728f3a39f0a43ba Mon Sep 17 00:00:00 2001
>From: mxbeaulieu <maxime.beaulieu@inlibro.com>
>Date: Thu, 13 Aug 2015 13:40:17 -0400
>Subject: [PATCH] Bug 12772 - Renames atomic update file, .pl -> .perl
>
>	renamed:    update_13624_overduerules_transport_type.pl -> update_13624_overduerules_transport_type.perl
>---
> .../update_13624_overduerules_transport_type.perl  |   33 +++++++------
> .../update_13624_overduerules_transport_type.pl    |   51 --------------------
> 2 files changed, 17 insertions(+), 67 deletions(-)
> delete mode 100755 installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl
>
>diff --git a/installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.perl b/installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.perl
>index be3af3c..bcadb59 100755
>--- a/installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.perl
>+++ b/installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.perl
>@@ -14,19 +14,17 @@ print "Will do : Bug 13624 - Remove columns branchcode, categorytype from table
>         `overduerules_id` int(11) NOT NULL AUTO_INCREMENT,
>         `branchcode` varchar(10) NOT NULL DEFAULT '',
>         `categorycode` varchar(10) NOT NULL DEFAULT '',
>-        `delay1` int(4) DEFAULT NULL,
>-        `letter1` varchar(20) DEFAULT NULL,
>-        `debarred1` varchar(1) DEFAULT '0',
>-        `delay2` int(4) DEFAULT NULL,
>-        `debarred2` varchar(1) DEFAULT '0',
>-        `letter2` varchar(20) DEFAULT NULL,
>-        `delay3` int(4) DEFAULT NULL,
>-        `letter3` varchar(20) DEFAULT NULL,
>-        `debarred3` int(1) DEFAULT '0',
>-        PRIMARY KEY (`overduerules_id`),
>-        UNIQUE KEY `overduerules_branch_cat` (`branchcode`,`categorycode`)
>+        `itemtype` varchar(10) default '',
>+        `onhold` tinyint(1) default 0,
>+        `delay` int(4) NOT NULL default 1,
>+        `letter` varchar(20) default NULL,
>+        `debarred` varchar(1) default 0,
>+        PRIMARY KEY (`overduerules_id`)
>         ) ENGINE=InnoDB DEFAULT CHARSET=utf8;");
>-    $dbh->do("INSERT INTO overduerules(branchcode, categorycode, delay1, letter1, debarred1, delay2, debarred2, letter2, delay3, letter3, debarred3) SELECT * FROM old_overduerules");
>+     foreach my $i (1..3){
>+        $dbh->do("INSERT INTO overduerules (delay, letter, debarred, branchcode, categorycode) ".
>+                 "SELECT delay$i AS delay, letter$i AS letter, debarred$i as debarred, branchcode, categorycode FROM old_overduerules");
>+     }
>     $dbh->do("DROP TABLE old_overduerules");
>     $dbh->do("ALTER TABLE overduerules_transport_types
>               ADD COLUMN overduerules_id int(11) NOT NULL");
>@@ -36,11 +34,14 @@ print "Will do : Bug 13624 - Remove columns branchcode, categorytype from table
>               DROP FOREIGN KEY overduerules_fk,
>               ADD FOREIGN KEY overduerules_transport_types_fk (overduerules_id) REFERENCES overduerules (overduerules_id) ON DELETE CASCADE ON UPDATE CASCADE,
>               DROP COLUMN branchcode,
>-              DROP COLUMN categorycode");
>-    my $s = $dbh->prepare("INSERT INTO overduerules_transport_types (overduerules_id, id, letternumber, message_transport_type) "
>-                         ." VALUES((SELECT overduerules_id FROM overduerules WHERE branchcode = ? AND categorycode = ?),?,?,?)");
>+              DROP COLUMN categorycode,
>+              DROP COLUMN letternumber");
>+    my $s = $dbh->prepare(
>+        "INSERT INTO overduerules_transport_types (overduerules_id, id, message_transport_type) ".
>+        "VALUES((SELECT overduerules_id FROM overduerules WHERE branchcode = ? AND categorycode = ?),?,?)"
>+    );
>     foreach my $mtt(@$mtts){
>-        $s->execute($mtt->{branchcode}, $mtt->{categorycode}, $mtt->{id}, $mtt->{letternumber}, $mtt->{message_transport_type} );
>+        $s->execute($mtt->{branchcode}, $mtt->{categorycode}, $mtt->{id}, $mtt->{message_transport_type} );
>     }
>     $dbh->do("SET FOREIGN_KEY_CHECKS=1");
> #    print "Upgrade to $DBversion done (Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types)\n";
>diff --git a/installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl b/installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl
>deleted file mode 100755
>index bcadb59..0000000
>--- a/installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl
>+++ /dev/null
>@@ -1,51 +0,0 @@
>-#! /usr/bin/perl
>-
>-use strict;
>-use warnings;
>-use C4::Context;
>-my $dbh=C4::Context->dbh;
>-
>-print "Will do : Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types\n";
>-
>-#if ( CheckVersion($DBversion) ) {
>-    $dbh->do("SET FOREIGN_KEY_CHECKS=0");
>-    $dbh->do("ALTER TABLE overduerules RENAME old_overduerules");
>-    $dbh->do("CREATE TABLE overduerules (
>-        `overduerules_id` int(11) NOT NULL AUTO_INCREMENT,
>-        `branchcode` varchar(10) NOT NULL DEFAULT '',
>-        `categorycode` varchar(10) NOT NULL DEFAULT '',
>-        `itemtype` varchar(10) default '',
>-        `onhold` tinyint(1) default 0,
>-        `delay` int(4) NOT NULL default 1,
>-        `letter` varchar(20) default NULL,
>-        `debarred` varchar(1) default 0,
>-        PRIMARY KEY (`overduerules_id`)
>-        ) ENGINE=InnoDB DEFAULT CHARSET=utf8;");
>-     foreach my $i (1..3){
>-        $dbh->do("INSERT INTO overduerules (delay, letter, debarred, branchcode, categorycode) ".
>-                 "SELECT delay$i AS delay, letter$i AS letter, debarred$i as debarred, branchcode, categorycode FROM old_overduerules");
>-     }
>-    $dbh->do("DROP TABLE old_overduerules");
>-    $dbh->do("ALTER TABLE overduerules_transport_types
>-              ADD COLUMN overduerules_id int(11) NOT NULL");
>-    my $mtts = $dbh->selectall_arrayref("SELECT * FROM overduerules_transport_types", { Slice => {} });
>-    $dbh->do("DELETE FROM overduerules_transport_types");
>-    $dbh->do("ALTER TABLE overduerules_transport_types
>-              DROP FOREIGN KEY overduerules_fk,
>-              ADD FOREIGN KEY overduerules_transport_types_fk (overduerules_id) REFERENCES overduerules (overduerules_id) ON DELETE CASCADE ON UPDATE CASCADE,
>-              DROP COLUMN branchcode,
>-              DROP COLUMN categorycode,
>-              DROP COLUMN letternumber");
>-    my $s = $dbh->prepare(
>-        "INSERT INTO overduerules_transport_types (overduerules_id, id, message_transport_type) ".
>-        "VALUES((SELECT overduerules_id FROM overduerules WHERE branchcode = ? AND categorycode = ?),?,?)"
>-    );
>-    foreach my $mtt(@$mtts){
>-        $s->execute($mtt->{branchcode}, $mtt->{categorycode}, $mtt->{id}, $mtt->{message_transport_type} );
>-    }
>-    $dbh->do("SET FOREIGN_KEY_CHECKS=1");
>-#    print "Upgrade to $DBversion done (Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types)\n";
>-#   SetVersion ($DBversion);
>-#}
>-
>-print "\nDone\n";
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 12772: 41477 | 41478 | 41479 | 41480 | 41855 | 42126 | 45184 | 45185 | 45186 | 45187 | 45188 | 45189 | 45190 | 45191 | 45192 | 45193 | 45194 | 45195 | 45196 | 45197 | 45198 | 45199 | 45200 | 45201 | 45202 | 45203 | 45204 | 45544 | 45545 | 45546 | 45547 | 45548 | 45549 | 45550 | 45551 | 45552 | 56063 | 56077