Bugzilla – Attachment 45623 Details for
Bug 14641
Warns in subscription-add.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14641: Warns in subscription-add.pl
Bug-14641-Warns-in-subscription-addpl.patch (text/plain), 978 bytes, created by
Aleisha Amohia
on 2015-12-13 22:06:29 UTC
(
hide
)
Description:
Bug 14641: Warns in subscription-add.pl
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2015-12-13 22:06:29 UTC
Size:
978 bytes
patch
obsolete
>From ed1ce36b45e84a758b09e9cd7b6af192464d673c Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Sun, 13 Dec 2015 22:04:09 +0000 >Subject: [PATCH] Bug 14641: Warns in subscription-add.pl > >These warns now appear on line 242. >Have changed get_letter_loop() to be empty unless given a value ( get_letter_loop //= '') > >To test: >1) Reproduce warns by clicking New Subscription >2) Apply patch >3) Click New Subscription again >4) Confirm warns are gone >--- > serials/subscription-add.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/serials/subscription-add.pl b/serials/subscription-add.pl >index 1790866..080506f 100755 >--- a/serials/subscription-add.pl >+++ b/serials/subscription-add.pl >@@ -236,7 +236,7 @@ if ($op eq 'addsubscription') { > } > > sub get_letter_loop { >- my ($selected_lettercode) = @_; >+ my ($selected_lettercode) //= ''; > my $letters = GetLetters({ module => 'serial' }); > return [ > map { >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14641
:
41325
|
45623
|
46500
|
46560
|
46580