Bugzilla – Attachment 45737 Details for
Bug 15252
Patron search on start with does not work with several terms
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15252 - correct UT searchtype value is contain and not contains
Bug-15252---correct-UT-searchtype-value-is-contain.patch (text/plain), 4.12 KB, created by
Marc Véron
on 2015-12-16 17:44:38 UTC
(
hide
)
Description:
Bug 15252 - correct UT searchtype value is contain and not contains
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2015-12-16 17:44:38 UTC
Size:
4.12 KB
patch
obsolete
>From 62d7b4154bdcb0cb0cd569aff88884d3f74ef704 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 25 Nov 2015 13:48:07 +0100 >Subject: [PATCH] Bug 15252 - correct UT searchtype value is contain and not > contains >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Tested 4 patches together, works as expected >Signed-off-by: Marc Véron <veron@veron.ch> >--- > t/DataTables/Members.t | 2 +- > t/db_dependent/Utils/Datatables_Members.t | 16 ++++++++-------- > 2 files changed, 9 insertions(+), 9 deletions(-) > >diff --git a/t/DataTables/Members.t b/t/DataTables/Members.t >index 942f93f..c9dcc7f 100644 >--- a/t/DataTables/Members.t >+++ b/t/DataTables/Members.t >@@ -6,7 +6,7 @@ use_ok( "C4::Utils::DataTables::Members" ); > my $patrons = C4::Utils::DataTables::Members::search({ > searchmember => "Doe", > searchfieldstype => 'standard', >- searchtype => 'contains' >+ searchtype => 'contain' > }); > > isnt( $patrons->{iTotalDisplayRecords}, undef, "The iTotalDisplayRecords key is defined"); >diff --git a/t/db_dependent/Utils/Datatables_Members.t b/t/db_dependent/Utils/Datatables_Members.t >index 57b42f7..9f8cda8 100644 >--- a/t/db_dependent/Utils/Datatables_Members.t >+++ b/t/db_dependent/Utils/Datatables_Members.t >@@ -104,7 +104,7 @@ my %dt_params = ( > my $search_results = C4::Utils::DataTables::Members::search({ > searchmember => "John Doe", > searchfieldstype => 'standard', >- searchtype => 'contains', >+ searchtype => 'contain', > branchcode => $branchcode, > dt_params => \%dt_params > }); >@@ -120,7 +120,7 @@ ok( $search_results->{ patrons }[0]->{ cardnumber } eq $john_doe{ cardnumber } > $search_results = C4::Utils::DataTables::Members::search({ > searchmember => "Jane Doe", > searchfieldstype => 'standard', >- searchtype => 'contains', >+ searchtype => 'contain', > branchcode => $branchcode, > dt_params => \%dt_params > }); >@@ -136,7 +136,7 @@ is( $search_results->{ patrons }[0]->{ cardnumber }, > $search_results = C4::Utils::DataTables::Members::search({ > searchmember => "John", > searchfieldstype => 'standard', >- searchtype => 'contains', >+ searchtype => 'contain', > branchcode => $branchcode, > dt_params => \%dt_params > }); >@@ -156,7 +156,7 @@ is( $search_results->{ patrons }[1]->{ cardnumber }, > $search_results = C4::Utils::DataTables::Members::search({ > searchmember => "Doe", > searchfieldstype => 'standard', >- searchtype => 'contains', >+ searchtype => 'contain', > branchcode => $branchcode, > dt_params => \%dt_params > }); >@@ -176,7 +176,7 @@ is( $search_results->{ patrons }[1]->{ cardnumber }, > $search_results = C4::Utils::DataTables::Members::search({ > searchmember => "john.doe", > searchfieldstype => 'standard', >- searchtype => 'contains', >+ searchtype => 'contain', > branchcode => $branchcode, > dt_params => \%dt_params > }); >@@ -187,7 +187,7 @@ is( $search_results->{ iTotalDisplayRecords }, 1, > $search_results = C4::Utils::DataTables::Members::search({ > searchmember => "john.doe", > searchfieldstype => 'userid', >- searchtype => 'contains', >+ searchtype => 'contain', > branchcode => $branchcode, > dt_params => \%dt_params > }); >@@ -211,7 +211,7 @@ t::lib::Mocks::mock_preference('ExtendedPatronAttributes', 1); > $search_results = C4::Utils::DataTables::Members::search({ > searchmember => "common user", > searchfieldstype => 'standard', >- searchtype => 'contains', >+ searchtype => 'contain', > branchcode => $branchcode, > dt_params => \%dt_params > }); >@@ -222,7 +222,7 @@ t::lib::Mocks::mock_preference('ExtendedPatronAttributes', 0); > $search_results = C4::Utils::DataTables::Members::search({ > searchmember => "common user", > searchfieldstype => 'standard', >- searchtype => 'contains', >+ searchtype => 'contain', > branchcode => $branchcode, > dt_params => \%dt_params > }); >-- >1.7.10.4
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=45737">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15252
:
45131
|
45132
|
45133
|
45134
|
45300
|
45301
|
45302
|
45303
|
45390
|
45391
|
45392
|
45393
|
45395
|
45401
|
45403
|
45405
|
45406
|
45407
|
45735
|
45736
|
45737
|
45738
|
45830
|
45831