Bugzilla – Attachment 4574 Details for
Bug 2505
Omnibus: Enable Perl warnings in all modules and scripts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Supplementary patch
0001-Bug-2505-Suppress-some-warnings-emitted-by-members-h.patch (text/plain), 1.58 KB, created by
Colin Campbell
on 2011-07-07 10:55:04 UTC
(
hide
)
Description:
Supplementary patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2011-07-07 10:55:04 UTC
Size:
1.58 KB
patch
obsolete
>From 604c15f9dee75f018c94da7727e11dee096330ed Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Mon, 31 Jan 2011 18:09:40 +0000 >Subject: [PATCH] Bug 2505: Suppress some warnings emitted by members-home.pl >Content-Type: text/plain; charset="utf-8" > >an undefined value in branch and the undef selected >can generate a large amount of warning noise >--- > members/members-home.pl | 13 +++++++------ > 1 files changed, 7 insertions(+), 6 deletions(-) > >diff --git a/members/members-home.pl b/members/members-home.pl >index 964fdb7..830800e 100755 >--- a/members/members-home.pl >+++ b/members/members-home.pl >@@ -31,6 +31,8 @@ my $query = new CGI; > my $branch = $query->param('branchcode'); > my $template_name; > >+$branch = q{} unless defined $branch; >+ > my ($template, $loggedinuser, $cookie) > = get_template_and_user({template_name => "members/member.tmpl", > query => $query, >@@ -42,13 +44,12 @@ my ($template, $loggedinuser, $cookie) > > my $branches = GetBranches; > my @branchloop; >-foreach (sort { $branches->{$a}->{branchname} cmp $branches->{$b}->{branchname} } keys %$branches) { >- my $selected = 1 if $branches->{$_}->{branchcode} eq $branch; >- my %row = ( value => $_, >- selected => $selected, >+foreach (sort { $branches->{$a}->{branchname} cmp $branches->{$b}->{branchname} } keys %{$branches}) { >+ push @branchloop, { >+ value => $_, >+ selected => ($branches->{$_}->{branchcode} eq $branch), > branchname => $branches->{$_}->{branchname}, >- ); >- push @branchloop, \%row; >+ }; > } > > my @categories; >-- >1.7.6 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2505
:
686
|
687
|
688
|
689
|
690
|
691
|
692
|
693
|
694
|
695
|
696
|
697
|
698
|
699
|
700
|
701
|
702
|
703
|
704
|
705
|
706
|
707
|
708
|
709
|
2223
|
3884
|
4574
|
8209
|
8317
|
8322
|
8373
|
9034
|
9035
|
9036
|
34442