Bugzilla – Attachment 45776 Details for
Bug 7728
Fixing subscription endddate inconsistency: should be empty when the subscription is running
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7728: fix subs history end date consistency
Bug-7728-fix-subs-history-end-date-consistency.patch (text/plain), 1.41 KB, created by
Biblibre Sandboxes
on 2015-12-17 14:48:35 UTC
(
hide
)
Description:
Bug 7728: fix subs history end date consistency
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2015-12-17 14:48:35 UTC
Size:
1.41 KB
patch
obsolete
>From 40a7c92e9b56f55068d85f836a8c0a830a2d025e Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Wed, 9 Dec 2015 10:25:43 +0000 >Subject: [PATCH] Bug 7728: fix subs history end date consistency > >Without this patch, there is an inconsistency in subscriptions: > * a new subscription has no history end date set (as expected) > * if you renew it, a date is set. > >This patch removes the setting of the history end date during renewal > >Test plan: > * create a subscription, go to subscription-detail.pl page, tab "Summary". No History end date is set > * renew the subscription => a date has been set > * apply the patch > * create another subscription > * renew it => no history end date has been set > * sign-off > >Signed-off-by: beroud <isabelle.beroud@univ-lyon3.fr> >--- > C4/Serials.pm | 7 ------- > 1 file changed, 7 deletions(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index 237e459..13fa901 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -1519,13 +1519,6 @@ sub ReNewSubscription { > |; > $sth = $dbh->prepare($query); > $sth->execute( $enddate, $subscriptionid ); >- $query = qq| >- UPDATE subscriptionhistory >- SET histenddate=? >- WHERE subscriptionid=? >- |; >- $sth = $dbh->prepare($query); >- $sth->execute( $enddate, $subscriptionid ); > > logaction( "SERIAL", "RENEW", $subscriptionid, "" ) if C4::Context->preference("SubscriptionLog"); > return; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7728
:
8240
|
45529
|
45776
|
47303
|
58813
|
58814
|
58815
|
61212
|
61213
|
61214
|
61215