Bugzilla – Attachment 45837 Details for
Bug 8643
Add ability to mark some MARC tags and subfields as important and alert on saving the record if they are found to be empty
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8643: (follow-up) atomic update
Bug-8643-follow-up-atomic-update.patch (text/plain), 2.43 KB, created by
Bernardo Gonzalez Kriegel
on 2015-12-18 14:53:04 UTC
(
hide
)
Description:
Bug 8643: (follow-up) atomic update
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2015-12-18 14:53:04 UTC
Size:
2.43 KB
patch
obsolete
>From 91ef6580f40efe28605fb5f03281c37aa8823066 Mon Sep 17 00:00:00 2001 >From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Date: Fri, 18 Dec 2015 11:40:02 -0300 >Subject: [PATCH] Bug 8643: (follow-up) atomic update > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >--- > .../mysql/atomicupdate/bug-8643-add_important_constraint.sql | 10 ++++++++++ > installer/data/mysql/updatedatabase.pl | 8 -------- > 2 files changed, 10 insertions(+), 8 deletions(-) > create mode 100644 installer/data/mysql/atomicupdate/bug-8643-add_important_constraint.sql > >diff --git a/installer/data/mysql/atomicupdate/bug-8643-add_important_constraint.sql b/installer/data/mysql/atomicupdate/bug-8643-add_important_constraint.sql >new file mode 100644 >index 0000000..0ffb746 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug-8643-add_important_constraint.sql >@@ -0,0 +1,10 @@ >+ALTER TABLE marc_subfield_structure ADD COLUMN important TINYINT(4) NOT NULL DEFAULT 0 AFTER mandatory; >+ALTER TABLE marc_tag_structure ADD COLUMN important TINYINT(4) NOT NULL DEFAULT 0 AFTER frameworkcode; >+ >+-- $DBversion = "3.23.00.XXX"; >+-- if ( CheckVersion($DBversion) ) { >+-- $dbh->do("ALTER TABLE marc_subfield_structure ADD COLUMN important TINYINT(4) NOT NULL DEFAULT 0 AFTER mandatory"); >+-- $dbh->do("ALTER TABLE marc_tag_structure ADD COLUMN important TINYINT(4) NOT NULL DEFAULT 0 AFTER frameworkcode"); >+-- print "Upgrade to $DBversion done (Bug 8643 - Add important constraint to marc subfields)\n"; >+-- SetVersion($DBversion); >+-- } >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 160f06a..b478c9b 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -11391,14 +11391,6 @@ if ( CheckVersion($DBversion) ) { > SetVersion ($DBversion); > } > >-$DBversion = "XXX"; >-if ( CheckVersion($DBversion) ) { >- $dbh->do("ALTER TABLE `marc_subfield_structure` ADD COLUMN `important` TINYINT(4) NOT NULL DEFAULT 0 AFTER `mandatory`"); >- $dbh->do("ALTER TABLE `marc_tag_structure` ADD COLUMN `important` TINYINT(4) NOT NULL DEFAULT 0 AFTER `frameworkcode`"); >- print "Upgrade to $DBversion done (Bug 8643 - Add important constraint to marc subfields)\n"; >- SetVersion($DBversion); >-} >- > # DEVELOPER PROCESS, search for anything to execute in the db_update directory > # SEE bug 13068 > # if there is anything in the atomicupdate, read and execute it. >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8643
:
11621
|
11622
|
30640
|
31032
|
40232
|
40237
|
41259
|
41261
|
41264
|
41265
|
45834
|
45835
|
45836
|
45837
|
60554
|
60555
|
65148
|
65149
|
65682
|
72154
|
72155
|
72156
|
72157
|
73591
|
73808
|
73809
|
73810
|
73811
|
73812
|
73813
|
73814
|
73815
|
73816
|
73817
|
73818
|
74267
|
74268
|
74269
|
74270
|
74271
|
74272
|
74273
|
81032
|
85982
|
91537
|
92081
|
92384
|
96625
|
96627
|
97325
|
97326
|
98607
|
98608
|
98702
|
98703
|
98712