Bugzilla – Attachment 4584 Details for
Bug 6531
clicking print button in opac causes 404 error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Signed-off patch
0001-SIGNED-OFF-Fix-for-Bug-6531-clicking-print-button-in.patch (text/plain), 3.21 KB, created by
Magnus Enger
on 2011-07-07 22:47:26 UTC
(
hide
)
Description:
Signed-off patch
Filename:
MIME Type:
Creator:
Magnus Enger
Created:
2011-07-07 22:47:26 UTC
Size:
3.21 KB
patch
obsolete
>From b2a99c5c8840d5aba6fb72061468798895d0d912 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 7 Jul 2011 10:01:34 -0400 >Subject: [PATCH] [SIGNED-OFF] Fix for Bug 6531 - clicking print button in opac causes 404 error > >opac-detail and opac-ISBDdetail both use window.print(), so I've >added that to opac-MARCdetail as well. I've also eliminated the >"javascript:" pseudo-protocol because it's pointless. I'd >prefer to have a real link for non-js users but that will have >to wait for another bug. > >After applying this patch users with JS enabled should get a >print prompt after clicking the "Print" link on opac-MARCdetail.pl > >Signed-off-by: Magnus Enger <magnus@enger.priv.no> >--- > .../opac-tmpl/prog/en/modules/opac-ISBDdetail.tt | 2 +- > .../opac-tmpl/prog/en/modules/opac-MARCdetail.tt | 2 +- > koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-ISBDdetail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-ISBDdetail.tt >index 35fffc8..f9984a7 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-ISBDdetail.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-ISBDdetail.tt >@@ -62,7 +62,7 @@ > [% END %] > [% END %] > [% END %] >- <li><a class="print" href="javascript:window.print();">Print</a></li> >+ <li><a class="print" href="#" onclick="window.print();">Print</a></li> > [% IF ( virtualshelves ) %] > [% IF ( opacuserlogin ) %] [% IF ( loggedinusername ) %] > <li><a class="addtoshelf" href="/cgi-bin/koha/opac-addbybiblionumber.pl?biblionumber=[% biblionumber %]" onclick="Dopop('opac-addbybiblionumber.pl?biblionumber=[% biblionumber %]'); return false;"> >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-MARCdetail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-MARCdetail.tt >index 68b0148..284154e 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-MARCdetail.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-MARCdetail.tt >@@ -217,7 +217,7 @@ $(document).ready(function(){ > [% END %] > [% END %] > [% END %] >- <li><a class="print" href="/cgi-bin/koha/opac-detailprint.pl?biblionumber=[% biblionumber %]" onclick="Dopop('opac-detailprint.pl?biblionumber=[% biblionumber %]'); return false;"> >+ <li><a class="print" href="#" onclick="window.print();"> > Print > </a></li> > [% IF ( virtualshelves ) %] >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >index 01a66a3..c247c77 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >@@ -808,7 +808,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () { > [% END %] > [% END %] > [% END %] >- <li><a class="print" href="javascript:window.print();">Print</a></li> >+ <li><a class="print" href="#" onclick="window.print();">Print</a></li> > [% IF ( virtualshelves ) %] > [% IF ( opacuserlogin ) %][% IF ( loggedinusername ) %] > <li><a class="addtoshelf" href="/cgi-bin/koha/opac-addbybiblionumber.pl?biblionumber=[% biblionumber %]" onclick="Dopop('opac-addbybiblionumber.pl?biblionumber=[% biblionumber %]'); return false;"> >-- >1.7.4.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6531
:
4576
| 4584