Attachment 45905 Details for Bug 15304 – Bug 15304 - Remove Norwegian strings from nl-search.tt

[patch] Bug 15304 - Remove Norwegian strings from nl-search.tt

Bug-15304---Remove-Norwegian-strings-from-nl-searc.patch (text/plain), 9.24 KB, created by Magnus Enger on 2015-12-22 12:30:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Magnus Enger

Created: 2015-12-22 12:30:53 UTC

Size: 9.24 KB

patch

obsolete

>From 4a53736966ec9dd628885346aeef4e409dc957fe Mon Sep 17 00:00:00 2001
>From: Magnus Enger <magnus@libriotech.no>
>Date: Tue, 8 Dec 2015 21:11:58 +0100
>Subject: [PATCH] Bug 15304 - Remove Norwegian strings from nl-search.tt
>
>When nl-search.pl gets data from the Norwegian national patron
>database, it does so in an XML format that has Norwegian element
>names. nl-search.pl displays the data with the Noregian element
>names as labels. This means Norwegian words turn up in translations,
>which is messy. This patch replaces the Norwegian labels with
>English ones.
>
>To test:
>- Only Norwegian libraries and vendors get access to search against
> the national patron database, so a proper functional test is not
> possible
>- Alternative 1: Just have a look at the nl-search.tt template
> before and after the patch and verify that after the patch the
> Norwegian strings that would be visible to a user are gone
>- Alternative 2:
> - Verify that e.g. en-GB-staff-prog.po contains the Norwegian
> string "kjonn"
> - Apply the patch
> - Create new .po files with e.g. "./translate create en-GB"
> - Verify that "kjonn" is now gone from en-GB-staff-prog.po
>
>Version 2: Tweak a couple of labels to be more in line with labels used
>elsewhere in Koha, to avoid variants when translating.
>
>Version 3: Replace e.g. "Gender: " with "Gender: " to
>avoid similar-except-for-whitespace strings in translation.
>---
> .../prog/en/modules/members/nl-search.tt | 80 +++++++++++-----------
> 1 file changed, 40 insertions(+), 40 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/nl-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/nl-search.tt
>index b8a9791..ae06764 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/nl-search.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/nl-search.tt
>@@ -80,46 +80,46 @@
> <div class="rows">
> <h4>[% p.navn | html_entity %]</h4>
> <ol>
>-[% IF ( p.kjonn ) %]<li>kjonn: [% p.kjonn | html_entity %]</li>[% END %]
>-[% IF ( p.fdato ) %]<li>fdato: [% p.fdato | html_entity %]</li>[% END %]
>-[% IF ( p.lnr ) %]<li>lnr: [% p.lnr | html_entity %]</li>[% END %]
>-[% IF ( p.fnr_hash ) %]<li>fnr_hash: [% p.fnr_hash | html_entity %]</li>[% END %]
>-
>-[% IF ( p.epost ) %]<li>epost: [% p.epost | html_entity %]</li>[% END %]
>-[% IF ( p.epost_sjekk ) %]<li>epost_sjekk: [% p.epost_sjekk | html_entity %]</li>[% END %]
>-
>-[% IF ( p.tlf_mobil ) %]<li>tlf_mobil: [% p.tlf_mobil | html_entity %]</li>[% END %]
>-[% IF ( p.tlf_hjemme ) %]<li>tlf_hjemme: [% p.tlf_hjemme | html_entity %]</li>[% END %]
>-[% IF ( p.tlf_jobb ) %]<li>tlf_jobb: [% p.tlf_jobb | html_entity %]</li>[% END %]
>-
>-[% IF ( p.p_adresse1 ) %]<li>p_adresse1: [% p.p_adresse1 | html_entity %]</li>[% END %]
>-[% IF ( p.p_adresse2 ) %]<li>p_adresse2: [% p.p_adresse2 | html_entity %]</li>[% END %]
>-[% IF ( p.p_postnr ) %]<li>p_postnr: [% p.p_postnr | html_entity %]</li>[% END %]
>-[% IF ( p.p_sted ) %]<li>p_sted: [% p.p_sted | html_entity %]</li>[% END %]
>-[% IF ( p.p_land ) %]<li>p_land: [% p.p_land | html_entity %]</li>[% END %]
>-[% IF ( p.p_sjekk ) %]<li>p_sjekk: [% p.p_sjekk | html_entity %]</li>[% END %]
>-
>-[% IF ( p.m_adresse1 ) %]<li>m_adresse1: [% p.m_adresse1 | html_entity %]</li>[% END %]
>-[% IF ( p.m_adresse2 ) %]<li>m_adresse2: [% p.m_adresse2 | html_entity %]</li>[% END %]
>-[% IF ( p.m_postnr ) %]<li>m_postnr: [% p.m_postnr | html_entity %]</li>[% END %]
>-[% IF ( p.m_sted ) %]<li>m_sted: [% p.m_sted | html_entity %]</li>[% END %]
>-[% IF ( p.m_land ) %]<li>m_land: [% p.m_land | html_entity %]</li>[% END %]
>-[% IF ( p.m_sjek ) %]<li>m_sjekk: [% p.m_sjekk | html_entity %]</li>[% END %]
>-[% IF ( p.m_gyldig_til ) %]<li>m_gyldig_til: [% p.m_gyldig_til | html_entity %]</li>[% END %]
>-
>-[% IF ( p.pin ) %]<li>pin: [% p.pin | html_entity %]</li>[% END %]
>-[% IF ( p.passord ) %]<li>passsord: [% p.passord | html_entity %]</li>[% END %]
>-[% IF ( p.feide ) %]<li>feide: [% p.feide | html_entity %]</li>[% END %]
>-[% IF ( p.folkeregsjekk_dato ) %]<li>folkeregsjekk_dato: [% p.folkeregsjekk_dato | html_entity %]</li>[% END %]
>-
>-[% IF ( p.hjemmebibliotek ) %]<li>hjemmebibliotek: [% p.hjemmebibliotek | html_entity %]</li>[% END %]
>-[% IF ( p.opprettet ) %]<li>opprettet: [% p.opprettet | html_entity %]</li>[% END %]
>-[% IF ( p.opprettet_av ) %]<li>opprettet_av: [% p.opprettet_av | html_entity %]</li>[% END %]
>-[% IF ( p.sist_endret ) %]<li>sist_endret: [% p.sist_endret | html_entity %]</li>[% END %]
>-[% IF ( p.sist_endret_av ) %]<li>sist_endret_av: [% p.sist_endret_av | html_entity %]</li>[% END %]
>-[% IF ( p.gyldig_til ) %]<li>gyldig_til: [% p.gyldig_til | html_entity %]</li>[% END %]
>-
>-[% IF ( p.prim_kontakt ) %]<li>prim_kontakt: [% p.prim_kontakt | html_entity %]</li>[% END %]
>+[% IF ( p.kjonn ) %]<li>Gender: [% p.kjonn | html_entity %]</li>[% END %]
>+[% IF ( p.fdato ) %]<li>Date of birth: [% p.fdato | html_entity %]</li>[% END %]
>+[% IF ( p.lnr ) %]<li>Card number: [% p.lnr | html_entity %]</li>[% END %]
>+[% IF ( p.fnr_hash ) %]<li>Social security number hash: [% p.fnr_hash | html_entity %]</li>[% END %]
>+
>+[% IF ( p.epost ) %]<li>Email: [% p.epost | html_entity %]</li>[% END %]
>+[% IF ( p.epost_sjekk ) %]<li>Email check: [% p.epost_sjekk | html_entity %]</li>[% END %]
>+
>+[% IF ( p.tlf_mobil ) %]<li>Phone - mobile: [% p.tlf_mobil | html_entity %]</li>[% END %]
>+[% IF ( p.tlf_hjemme ) %]<li>Phone - home: [% p.tlf_hjemme | html_entity %]</li>[% END %]
>+[% IF ( p.tlf_jobb ) %]<li>Phone - work: [% p.tlf_jobb | html_entity %]</li>[% END %]
>+
>+[% IF ( p.p_adresse1 ) %]<li>Address: [% p.p_adresse1 | html_entity %]</li>[% END %]
>+[% IF ( p.p_adresse2 ) %]<li>Address 2: [% p.p_adresse2 | html_entity %]</li>[% END %]
>+[% IF ( p.p_postnr ) %]<li>Zip/Postal code: [% p.p_postnr | html_entity %]</li>[% END %]
>+[% IF ( p.p_sted ) %]<li>City: [% p.p_sted | html_entity %]</li>[% END %]
>+[% IF ( p.p_land ) %]<li>Country: [% p.p_land | html_entity %]</li>[% END %]
>+[% IF ( p.p_sjekk ) %]<li>Check: [% p.p_sjekk | html_entity %]</li>[% END %]
>+
>+[% IF ( p.m_adresse1 ) %]<li>Address: [% p.m_adresse1 | html_entity %]</li>[% END %]
>+[% IF ( p.m_adresse2 ) %]<li>Address 2: [% p.m_adresse2 | html_entity %]</li>[% END %]
>+[% IF ( p.m_postnr ) %]<li>Zip/Postal code: [% p.m_postnr | html_entity %]</li>[% END %]
>+[% IF ( p.m_sted ) %]<li>City: [% p.m_sted | html_entity %]</li>[% END %]
>+[% IF ( p.m_land ) %]<li>Country: [% p.m_land | html_entity %]</li>[% END %]
>+[% IF ( p.m_sjek ) %]<li>Check: [% p.m_sjekk | html_entity %]</li>[% END %]
>+[% IF ( p.m_gyldig_til ) %]<li>Valid until: [% p.m_gyldig_til | html_entity %]</li>[% END %]
>+
>+[% IF ( p.pin ) %]<li>PIN: [% p.pin | html_entity %]</li>[% END %]
>+[% IF ( p.passord ) %]<li>Password: [% p.passord | html_entity %]</li>[% END %]
>+[% IF ( p.feide ) %]<li>FEIDE: [% p.feide | html_entity %]</li>[% END %]
>+[% IF ( p.folkeregsjekk_dato ) %]<li>Population registry date check: [% p.folkeregsjekk_dato | html_entity %]</li>[% END %]
>+
>+[% IF ( p.hjemmebibliotek ) %]<li>Home library: [% p.hjemmebibliotek | html_entity %]</li>[% END %]
>+[% IF ( p.opprettet ) %]<li>Created: [% p.opprettet | html_entity %]</li>[% END %]
>+[% IF ( p.opprettet_av ) %]<li>Created by: [% p.opprettet_av | html_entity %]</li>[% END %]
>+[% IF ( p.sist_endret ) %]<li>Last changed: [% p.sist_endret | html_entity %]</li>[% END %]
>+[% IF ( p.sist_endret_av ) %]<li>Last changed by: [% p.sist_endret_av | html_entity %]</li>[% END %]
>+[% IF ( p.gyldig_til ) %]<li>Valid until: [% p.gyldig_til | html_entity %]</li>[% END %]
>+
>+[% IF ( p.prim_kontakt ) %]<li>Primary contact: [% p.prim_kontakt | html_entity %]</li>[% END %]
> </ol>
> 
> <form action="nl-search.pl" method="POST">
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 15304: 45512 | 45514 | 45608 | 45905 | 45945 | 45978