Attachment 46011 Details for Bug 14153 – Bug 14153: Noisy warns in admin/transport-cost-matrix.pl

[patch] Bug 14153: Noisy warns in admin/transport-cost-matrix.pl

Bug-14153-Noisy-warns-in-admintransport-cost-matri.patch (text/plain), 1.15 KB, created by Jonathan Druart on 2015-12-28 16:34:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-12-28 16:34:08 UTC

Size: 1.15 KB

patch

obsolete

>From 4fe68da4fee94034829699738223e06210c829c8 Mon Sep 17 00:00:00 2001
>From: Aleisha <aleishaamohia@hotmail.com>
>Date: Sun, 13 Dec 2015 22:24:05 +0000
>Subject: [PATCH] Bug 14153: Noisy warns in admin/transport-cost-matrix.pl
>
>To test:
>
>1) Go to Admin -> Transport cost matrix
>2) Notice the warns in the error log
>3) Apply the patch and refresh page
>4) Notice page still works but no warns in error log
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Amended patch: Init a $op variable, if it must be reused later.
>---
> admin/transport-cost-matrix.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/admin/transport-cost-matrix.pl b/admin/transport-cost-matrix.pl
>index 3197306..383318c 100755
>--- a/admin/transport-cost-matrix.pl
>+++ b/admin/transport-cost-matrix.pl
>@@ -42,7 +42,7 @@ my ($template, $loggedinuser, $cookie)
>                             });
> my $use_transport_cost_matrix = C4::Context->preference("UseTransportCostMatrix");
> 
>-my $update = $input->param('op') eq 'set-cost-matrix';
>+my $update = ( $input->param('op') // '' ) eq 'set-cost-matrix';
> 
> my ($cost_matrix, $have_matrix);
> unless ($update) {
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 14153: 38880 | 45628 | 46011 | 46065