Attachment 46073 Details for Bug 15429 – Bug 15429 UT for _parseletter modifying its parameter

[patch] Bug 15429 UT for _parseletter modifying its parameter

Bug-15429-UT-for-parseletter-modifying-its-paramet.patch (text/plain), 1.54 KB, created by Frédéric Demians on 2015-12-30 12:48:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Frédéric Demians

Created: 2015-12-30 12:48:31 UTC

Size: 1.54 KB

patch

obsolete

>From 56483bf02d5ef8488011b0a5f0b45e46e1d2e296 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr>
>Date: Wed, 30 Dec 2015 13:10:16 +0100
>Subject: [PATCH] Bug 15429 UT for _parseletter modifying its parameter
>
>Before/after applying the related patch, do:
>
>   prove -v t/db_dependent/Letters.t
>---
> t/db_dependent/Letters.t | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t
>index 2e0d854..2d8c9bb 100644
>--- a/t/db_dependent/Letters.t
>+++ b/t/db_dependent/Letters.t
>@@ -18,7 +18,7 @@
> # along with Koha; if not, see <http://www.gnu.org/licenses>.
> 
> use Modern::Perl;
>-use Test::More tests => 68;
>+use Test::More tests => 69;
> use Test::MockModule;
> use Test::Warn;
> 
>@@ -331,6 +331,13 @@ is( $prepared_letter->{content}, q|This one only contains the date: | . output_p
> 
> $dbh->do(q{INSERT INTO letter (module, code, name, title, content) VALUES ('claimacquisition','TESTACQCLAIM','Acquisition Claim','Item Not Received','<<aqbooksellers.name>>|<<aqcontacts.name>>|<order>Ordernumber <<aqorders.ordernumber>> (<<biblio.title>>) (<<aqorders.quantity>> ordered)</order>');});
> 
>+# Test that _parseletter doesn't modify its parameters bug 15429
>+{
>+    my $values = { dateexpiry => '2015-12-13', };
>+    C4::Letters::_parseletter($prepared_letter, 'borrowers', $values);
>+    is( $values->{dateexpiry}, '2015-12-13', "_parseletter doesn't modify its parameters" );
>+}
>+
> my $booksellerid = C4::Bookseller::AddBookseller(
>     {
>         name => "my vendor",
>-- 
>2.6.2

Actions: View | Diff | Splinter Review

Attachments on bug 15429: 45994 | 46072 | 46073 | 46076 | 46077 | 46160