Bugzilla – Attachment 46124 Details for
Bug 12375
Store serials enumeration data in separate fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12375 [3] - Store serials enumeration data in separate fields
Bug-12375-3---Store-serials-enumeration-data-in-se.patch (text/plain), 4.52 KB, created by
Kyle M Hall (khall)
on 2015-12-31 12:31:41 UTC
(
hide
)
Description:
Bug 12375 [3] - Store serials enumeration data in separate fields
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-12-31 12:31:41 UTC
Size:
4.52 KB
patch
obsolete
>From 736bcf457cb01b0835f7af041d235f89ac337e3a Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 5 Jun 2014 10:52:30 -0400 >Subject: [PATCH] Bug 12375 [3] - Store serials enumeration data in separate > fields > >Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> >--- > C4/Serials.pm | 59 +++++++++++++++++++++++++++++++++++++++++------------------ > 1 file changed, 41 insertions(+), 18 deletions(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index 237e459..1f2cbc0 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -32,6 +32,7 @@ use C4::Serials::Frequency; > use C4::Serials::Numberpattern; > use Koha::AdditionalField; > use Koha::DateUtils; >+use Koha::Database; > > use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS); > >@@ -1187,12 +1188,13 @@ sub ModSerialStatus { > # next date (calculated from actual date & frequency parameters) > my $nextpublisheddate = GetNextDate($subscription, $publisheddate, 1); > my $nextpubdate = $nextpublisheddate; >- NewIssue( $newserialseq, $subscriptionid, $subscription->{'biblionumber'}, 1, $nextpubdate, $nextpubdate ); > $query = "UPDATE subscription SET lastvalue1=?, lastvalue2=?, lastvalue3=?, innerloop1=?, innerloop2=?, innerloop3=? > WHERE subscriptionid = ?"; > $sth = $dbh->prepare($query); > $sth->execute( $newlastvalue1, $newlastvalue2, $newlastvalue3, $newinnerloop1, $newinnerloop2, $newinnerloop3, $subscriptionid ); > >+ NewIssue( $newserialseq, $subscriptionid, $subscription->{'biblionumber'}, 1, $nextpubdate, $nextpubdate ); >+ > # check if an alert must be sent... (= a letter is defined & status became "arrived" > if ( $subscription->{letter} && $status == ARRIVED && $oldstatus != ARRIVED ) { > require C4::Letters; >@@ -1444,13 +1446,21 @@ sub NewSubscription { > > # calculate issue number > my $serialseq = GetSeq($subscription, $pattern) || q{}; >- $query = qq| >- INSERT INTO serial >- (serialseq,subscriptionid,biblionumber,status, planneddate, publisheddate) >- VALUES (?,?,?,?,?,?) >- |; >- $sth = $dbh->prepare($query); >- $sth->execute( $serialseq, $subscriptionid, $biblionumber, EXPECTED, $firstacquidate, $firstacquidate ); >+ >+ my $serial_rs = Koha::Database->new()->schema()->resultset('Serial'); >+ $serial_rs->create( >+ { >+ serialseq => $serialseq, >+ serialseq_x => $subscription->{'lastvalue1'}, >+ serialseq_y => $subscription->{'lastvalue2'}, >+ serialseq_z => $subscription->{'lastvalue3'}, >+ subscriptionid => $subscriptionid, >+ biblionumber => $biblionumber, >+ status => EXPECTED, >+ planneddate => $firstacquidate, >+ publisheddate => $firstacquidate, >+ } >+ ); > > logaction( "SERIAL", "ADD", $subscriptionid, "" ) if C4::Context->preference("SubscriptionLog"); > >@@ -1548,22 +1558,35 @@ sub NewIssue { > > return unless ($subscriptionid); > >+ my $schema = Koha::Database->new()->schema(); >+ >+ my $subscription = $schema->resultset('Subscription')->find( $subscriptionid ); >+ >+ my $serial = $schema->resultset('Serial')->create( >+ { >+ serialseq => $serialseq, >+ serialseq_x => $subscription->lastvalue1(), >+ serialseq_y => $subscription->lastvalue2(), >+ serialseq_z => $subscription->lastvalue3(), >+ subscriptionid => $subscriptionid, >+ biblionumber => $biblionumber, >+ status => $status, >+ planneddate => $planneddate, >+ publisheddate => $publisheddate, >+ publisheddatetext => $publisheddatetext, >+ notes => $notes, >+ } >+ ); >+ > my $dbh = C4::Context->dbh; >+ my $serialid = $serial->id(); >+ > my $query = qq| >- INSERT INTO serial (serialseq, subscriptionid, biblionumber, status, >- publisheddate, publisheddatetext, planneddate, notes) >- VALUES (?,?,?,?,?,?,?,?) >- |; >- my $sth = $dbh->prepare($query); >- $sth->execute( $serialseq, $subscriptionid, $biblionumber, $status, >- $publisheddate, $publisheddatetext, $planneddate, $notes ); >- my $serialid = $dbh->{'mysql_insertid'}; >- $query = qq| > SELECT missinglist,recievedlist > FROM subscriptionhistory > WHERE subscriptionid=? > |; >- $sth = $dbh->prepare($query); >+ my $sth = $dbh->prepare($query); > $sth->execute($subscriptionid); > my ( $missinglist, $recievedlist ) = $sth->fetchrow; > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12375
:
28675
|
28676
|
28677
|
28678
|
28679
|
28680
|
28681
|
28682
|
28683
|
28843
|
28844
|
28845
|
28846
|
29928
|
29929
|
30099
|
30100
|
30101
|
30102
|
30103
|
30104
|
30108
|
35155
|
35156
|
35157
|
35158
|
35159
|
35160
|
35161
|
40710
|
40711
|
40712
|
40713
|
40714
|
40715
|
40716
|
46122
|
46123
| 46124 |
46125
|
46126
|
46127
|
46128
|
46319