Bugzilla – Attachment 46173 Details for
Bug 14555
Warns in opac-search.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14555: Warns in opac-search.pl
Bug-14555-Warns-in-opac-searchpl.patch (text/plain), 1.18 KB, created by
Martin Stenberg
on 2016-01-01 13:12:20 UTC
(
hide
)
Description:
Bug 14555: Warns in opac-search.pl
Filename:
MIME Type:
Creator:
Martin Stenberg
Created:
2016-01-01 13:12:20 UTC
Size:
1.18 KB
patch
obsolete
>From d39d06e0ebfb87e98b5229b52e10f2b11b967441 Mon Sep 17 00:00:00 2001 >From: Martin Stenberg <martin@xinxidi.net> >Date: Mon, 21 Sep 2015 13:16:39 +0200 >Subject: [PATCH] Bug 14555: Warns in opac-search.pl > >Avoid use of uninitialized value in split > >== Test plan == >1. Go to opac advanced search >2. Click "Search" without any search query >3. Log file will show "Use of uninitialized value in split at ..." >4. Apply this patch >5. Repeat step 1 and 2 >6. Log file should no longer show "Use of uninitialized value in split at ..." > >Sponsored-by: Regionbibliotek Halland / County library of Halland >--- > opac/opac-search.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/opac/opac-search.pl b/opac/opac-search.pl >index bc703b3..3a399cb 100755 >--- a/opac/opac-search.pl >+++ b/opac/opac-search.pl >@@ -526,7 +526,8 @@ my @results; > > sub _input_cgi_parse { > my @elements; >- for my $this_cgi ( split('&',shift) ) { >+ my $query_cgi = shift or return @elements; >+ for my $this_cgi ( split('&',$query_cgi) ) { > next unless $this_cgi; > $this_cgi =~ /(.*?)=(.*)/; > push @elements, { input_name => $1, input_value => Encode::decode_utf8( uri_unescape($2) ) }; >-- >2.6.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14555
:
42718
|
46173
|
46294
|
46405