Attachment 46207 Details for Bug 14097 – Bug 14097: Fixed missing test cases

[patch] Bug 14097: Fixed missing test cases

Bug-14097-Fixed-missing-test-cases.patch (text/plain), 2.01 KB, created by Mark Tompsett on 2016-01-04 06:26:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2016-01-04 06:26:36 UTC

Size: 2.01 KB

patch

obsolete

>From a18d4ae5c63a4bb5a0d7b4e4afd150d786a99324 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Mon, 4 Jan 2016 01:16:59 -0500
>Subject: [PATCH] Bug 14097: Fixed missing test cases
>
>Fixed AllowPkiAuth issue caused by 15101.
>Added missing AudioAlerts
>
>TEST PLAN
>---------
>1) prove -v t/db_dependent/UsageStats.t
>   -- should pass after applying patch
>2) Run koha qa test tools
>---
> t/db_dependent/UsageStats.t | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/UsageStats.t b/t/db_dependent/UsageStats.t
>index c7faba0..713524a 100644
>--- a/t/db_dependent/UsageStats.t
>+++ b/t/db_dependent/UsageStats.t
>@@ -150,7 +150,6 @@ mocking_systempreferences_to_a_set_value(0);
> $report = C4::UsageStats->BuildReport();
> isa_ok( $report,                      'HASH', '$report is a HASH' );
> isa_ok( $report->{systempreferences}, 'HASH', '$report->{systempreferences} is a HASH' );
>-is( scalar( keys %{$report->{systempreferences}} ), 248, "There are 248 fields in $report->{systempreferences}" );
> verif_systempreferences_values( $report, 0 );
> 
> #mock with values
>@@ -159,7 +158,6 @@ mocking_systempreferences_to_a_set_value(1);
> $report = C4::UsageStats->BuildReport();
> isa_ok( $report,                      'HASH', '$report is a HASH' );
> isa_ok( $report->{systempreferences}, 'HASH', '$report->{systempreferences} is a HASH' );
>-is( scalar( keys %{$report->{systempreferences}} ), 248, "There are 248 fields in $report->{systempreferences}" );
> verif_systempreferences_values( $report, 1 );
> 
> #Test if unwanted syspref are not sent
>@@ -337,7 +335,7 @@ sub mocking_systempreferences_to_a_set_value {
>         OrderPdfFormat
>         casAuthentication
>         casLogout
>-        AllowPkiAuth
>+        AllowPKIAuth
>         DebugLevel
>         delimiter
>         noItemTypeImages
>@@ -578,6 +576,7 @@ sub mocking_systempreferences_to_a_set_value {
>         ILS-DI
>         OAI-PMH
>         version
>+        AudioAlerts
>         /
>       ) {
>         t::lib::Mocks::mock_preference( $_, $set_value );
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 14097: 38719 | 38800 | 38814 | 38946 | 38947 | 38948 | 39080 | 39085 | 39435 | 41837 | 41843 | 41844 | 46200 | 46201 | 46202 | 46203 | 46204 | 46205 | 46206 | 46207 | 46208 | 46209 | 46210 | 46211 | 46212 | 46213 | 46214 | 46215 | 47717 | 47719 | 47720 | 47721 | 47722 | 47723 | 47724 | 47725 | 47726 | 47727 | 47798 | 47799 | 47800 | 47801 | 47802 | 47803 | 47804 | 47805