Bugzilla – Attachment 46244 Details for
Bug 15466
Suggestions.t is failing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15466: Do not assume $values_in is a hashref
Bug-15466-Do-not-assume-valuesin-is-a-hashref.patch (text/plain), 940 bytes, created by
Jonathan Druart
on 2016-01-05 09:40:42 UTC
(
hide
)
Description:
Bug 15466: Do not assume $values_in is a hashref
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-01-05 09:40:42 UTC
Size:
940 bytes
patch
obsolete
>From 803f71a9fff859eef83e06cd6f6cc7503a6785df Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 5 Jan 2016 09:39:32 +0000 >Subject: [PATCH] Bug 15466: Do not assume $values_in is a hashref > >It could be undefined. >Test plan: >prove t/db_dependent/Suggestions.t >should return green. >--- > C4/Letters.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index e5c15ba..dc9574f 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -803,7 +803,7 @@ sub _parseletter { > > # Work on a local copy of $values_in (passed by reference) to avoid side effects > # in callers ( by changing / formatting values ) >- my $values = { %$values_in }; >+ my $values = $values_in ? { %$values_in } : {}; > > if ( $table eq 'borrowers' && $values->{'dateexpiry'} ){ > $values->{'dateexpiry'} = format_sqldatetime( $values->{'dateexpiry'} ); >-- >2.1.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=46244">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15466
:
46244
|
46246
|
46349