Attachment 46300 Details for Bug 14480 – Bug 14480: Silences warn from editing patron

[patch] Bug 14480: Silences warn from editing patron

Bug-14480-Silences-warn-from-editing-patron.patch (text/plain), 2.07 KB, created by Mark Tompsett on 2016-01-06 01:53:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2016-01-06 01:53:25 UTC

Size: 2.07 KB

patch

obsolete

>From 5d68ca5b933694a30b99d8747004a8a9c3d1d9ec Mon Sep 17 00:00:00 2001
>From: Aleisha <aleishaamohia@hotmail.com>
>Date: Tue, 29 Dec 2015 19:39:20 +0000
>Subject: [PATCH] Bug 14480: Silences warn from editing patron
>
>Argument "" isn't numeric in numeric lt (<)
>
>TEST PLAN
>---------
>1) Go to any patron in staff client
>2) Click 'Edit'
>3) Check error logs
>   -- warnings should exist.
>4) Apply patch
>5) Reload page
>   -- warnings should not be triggered.
>6) Add restriction and save
>7) Go back to edit screen
>   -- restriction should be shown
>8) Remove restriction and save
>9) Go back to edit screen
>   -- Should say "Patron is currently unrestricted"
>10) Run koha qa test tools.
>
>NOTE: Squashed, because it is a really small set of patches
>      and multiple commits does not make sense to me.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index e646890..aad9657 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -959,9 +959,7 @@
>               <fieldset class="rows">
>                 <legend>Patron restrictions</legend>
> 
>-                [% IF ( debarments.size < 1 ) %]
>-                    <p>Patron is currently unrestricted.</p>
>-                [% ELSE %]
>+                [% IF (debarments) %]
>                     <table>
>                         <thead>
>                             <tr>
>@@ -989,6 +987,8 @@
>                             [% END %]
>                         </tbody>
>                     </table>
>+                [% ELSE %]
>+                    <p>Patron is currently unrestricted.</p>
>                 [% END %]
>                 [% IF CAN_user_borrowers && CAN_user_circulate_manage_restrictions %]
>                     <p><a href="#" id="add_manual_restriction">Add manual restriction</a></p>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 14480: 40744 | 45677 | 45796 | 46025 | 46290 | 46300 | 46301 | 46305