Attachment 46365 Details for Bug 15493 – [SIGNED-OFF]Bug 15493: Use the correct CSV profile when exporting records from the export tool

[patch] [SIGNED-OFF]Bug 15493: Use the correct CSV profile when exporting records from the export tool

SIGNED-OFFBug-15493-Use-the-correct-CSV-profile-wh.patch (text/plain), 1.64 KB, created by Héctor Eduardo Castro Avalos on 2016-01-06 21:33:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Héctor Eduardo Castro Avalos

Created: 2016-01-06 21:33:12 UTC

Size: 1.64 KB

patch

obsolete

>From 3b56b9bf5e1fff51466c08ef2218901ca008e746 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 6 Jan 2016 16:17:10 +0000
>Subject: [PATCH] [SIGNED-OFF]Bug 15493: Use the correct CSV profile when
> exporting records from the export tool
>
>The CSV profile used is not the one the user has chosen, but the one
>defined in the pref ExportWithCsvProfile.
>
>It's caused by a wrong variable name csv_profile vs csv_profile_id
>
>Test plan:
>Define 1+ csv profiles
>Set ExportWithCsvProfile with 1 of these profile
>Use the export tool to export some records using a csv profile.
>Without this patch, the csv profile used, will always be the one defined
>in ExportWithCsvProfile.
>
>Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
>Works as descrived
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt
>index ba90c8f..83bc50a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt
>@@ -139,7 +139,7 @@ $(document).ready(function() {
>         </li>
>         <li class="csv_profiles">
>             <label for="bibs_csv_profile">CSV profile: </label>
>-            <select id="bibs_csv_profile" name="csv_profile">
>+            <select id="bibs_csv_profile" name="csv_profile_id">
>                 [% FOR csv_profile IN csv_profiles %]
>                     <option value="[% csv_profile.export_format_id %]">[% csv_profile.profile %]</option>
>                 [% END %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 15493: 46334 | 46365 | 46372