Attachment 46373 Details for Bug 12636 – [PASSED QA] Bug 12636: Do not display unique patron attributes in the batch patron modification

[patch] [PASSED QA] Bug 12636: Do not display unique patron attributes in the batch patron modification

PASSED-QA-Bug-12636-Do-not-display-unique-patron-a.patch (text/plain), 1.49 KB, created by Katrin Fischer on 2016-01-06 22:43:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-01-06 22:43:47 UTC

Size: 1.49 KB

patch

obsolete

>From c5a907614263f6ac6813abc05ee8872c231d9e7c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 21 Dec 2015 12:31:59 +0000
>Subject: [PATCH] [PASSED QA] Bug 12636: Do not display unique patron
> attributes in the batch patron modification
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Batch patron modification should not offer to update patron attributes
>with values which are designated as unique since such attributes are
>required to be unique to a single patron.
>
>Test plan:
>Create some patron attributes, some should be unique.
>Use the batch patron modification tool to modify patrons.
>With this patch, the patron attributes marked as unique won't be
>display anymore.
>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> tools/modborrowers.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl
>index 71588c0..7192c74 100755
>--- a/tools/modborrowers.pl
>+++ b/tools/modborrowers.pl
>@@ -107,6 +107,7 @@ if ( $op eq 'show' ) {
>     my $patron_categories = C4::Members::GetBorrowercategoryList;
>     for ( values %$patron_attribute_types ) {
>         my $attr_type = C4::Members::AttributeTypes->fetch( $_->{code} );
>+        next if $attr_type->{unique_id};
>         my $options = $attr_type->authorised_value_category
>             ? GetAuthorisedValues( $attr_type->authorised_value_category )
>             : undef;
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 12636: 45881 | 45911 | 46373 | 47346