Attachment 46376 Details for Bug 15357 – [PASSED QA] Bug 15357: Display existing holds even if no items exist

[patch] [PASSED QA] Bug 15357: Display existing holds even if no items exist

PASSED-QA-Bug-15357-Display-existing-holds-even-if.patch (text/plain), 2.31 KB, created by Katrin Fischer on 2016-01-06 23:00:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-01-06 23:00:04 UTC

Size: 2.31 KB

patch

obsolete

>From 0b673b7e569cf4992b852e6856f77527ea732669 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 14 Dec 2015 09:32:50 +0000
>Subject: [PATCH] [PASSED QA] Bug 15357: Display existing holds even if no
> items exist
>
>If all the items have been deleted for a record and holds exist, the
>holds are not displayed.
>You are not able to delete the items from the record detail page, but
>you can from the items page.
>
>Test plan:
>1 - Place 1 or more title level holds on a record.
>2 - Delete each item individually.
>3 - Note that you see the number of holds on the record details page
>With this patch, that holds are accessible via the holds tab.
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index 3152f7f..85f687a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -228,8 +228,9 @@ function checkMultiHold() {
>     [% ELSE %]
>         <strong>Cannot place hold:</strong> this record has no items attached.
>     [% END %]
>-    </ div>
>-[% ELSE %]
>+    </div>
>+[% END %]
>+
>   [% IF ( messagetransfert ) %]
> 		<div class="dialog message">
> 				<h2>Hold found for ([% nextreservtitle %]), please transfer</h2>
>@@ -247,7 +248,7 @@ function checkMultiHold() {
>     <h1>Confirm holds</h1>
>   [% END %]
> 
>-  [% UNLESS ( borrowernumber ) %]
>+  [% UNLESS borrowernumber OR noitems %]
>     [% IF ( messageborrower ) %]
>       <div class="dialog alert"><h3>Patron not found</h3><p>No patron with this name, please, try another</p> </div>
>     [% END %]
>@@ -296,7 +297,7 @@ function checkMultiHold() {
>             <input type="hidden" name="biblionumbers" value="[% biblionumbers %]"/>
>         [% END %]
>     </form>
>-  [% ELSE %]
>+  [% ELSIF NOT noitems %]
> 
> [% IF ( exceeded_maxreserves || alreadyreserved || none_available || alreadypossession || ageRestricted ) %]
>     <div class="dialog alert">
>@@ -851,7 +852,6 @@ function checkMultiHold() {
> </form>
> [% END %]
> [% END %]
>-[% END %]
> </div>
> </div>
> 
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 15357: 45630 | 45665 | 46376 | 46723