Bugzilla – Attachment 46381 Details for
Bug 12586
Record matching rules - Required match checks doesn't work with MARCXML
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12586 - Record matching rules - Required match checks doesn't work with MARCXML (follow-up)
Bug-12586---Record-matching-rules---Required-match.patch (text/plain), 1.67 KB, created by
David Cook
on 2016-01-07 03:26:20 UTC
(
hide
)
Description:
Bug 12586 - Record matching rules - Required match checks doesn't work with MARCXML (follow-up)
Filename:
MIME Type:
Creator:
David Cook
Created:
2016-01-07 03:26:20 UTC
Size:
1.67 KB
patch
obsolete
>From fd76129a66938cc8bd499b9b8d23b9bc17a1d558 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 7 Jan 2016 14:24:34 +1100 >Subject: [PATCH] Bug 12586 - Record matching rules - Required match checks > doesn't work with MARCXML (follow-up) > >The follow-up fixes a typo ('auth' to 'authority') and removes 'target_result' and 'target_biblio' >which were introduced, seemingly unnecessarily, by the first patch in the set. >--- > C4/Matcher.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Matcher.pm b/C4/Matcher.pm >index c8c3916..b6fae2d 100644 >--- a/C4/Matcher.pm >+++ b/C4/Matcher.pm >@@ -715,7 +715,7 @@ sub get_matches { > > # get rid of any that don't meet the required checks > %matches = map { _passes_required_checks($source_record, $matches{$_}->{record}, $self->{'required_checks'}) ? ($_ => $matches{$_}) : () } >- keys %matches unless ($self->{'record_type'} eq 'auth'); >+ keys %matches unless ($self->{'record_type'} eq 'authority'); > > my @results = (); > if ($self->{'record_type'} eq 'biblio') { >@@ -725,7 +725,7 @@ sub get_matches { > my $record_number; > my $result = C4::Biblio::TransformMarcToKoha(C4::Context->dbh, $target_record, ''); > $record_number = $result->{'biblionumber'}; >- push @results, { 'record_id' => $record_number, 'score' => $matches{$hashkey}->{score}, 'target_record' => $target_record, 'target_biblio' => $result }; >+ push @results, { 'record_id' => $record_number, 'score' => $matches{$hashkey}->{score}, }; > } > } elsif ($self->{'record_type'} eq 'authority') { > require C4::AuthoritiesMarc; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12586
:
29758
|
29948
|
46380
|
46381
|
54278