Attachment 46413 Details for Bug 15299 – Bug 15299: Ask for confirmation when deleting a report from second page

[patch] Bug 15299: Ask for confirmation when deleting a report from second page

Bug-15299-Ask-for-confirmation-when-deleting-a-rep.patch (text/plain), 1.59 KB, created by Liz Rea on 2016-01-08 00:30:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Liz Rea

Created: 2016-01-08 00:30:38 UTC

Size: 1.59 KB

patch

obsolete

>From 492a4fac941883c773a164c998d2466e3268fdba Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 7 Jan 2016 12:50:35 +0000
>Subject: [PATCH] Bug 15299: Ask for confirmation when deleting a report from
> second page
>
>Some link are hidden when loading the page, by DataTables, we need to
>use the delegate jQuery method to attach a handler to the click event
>for all delete links (the ones existing when loading the page, and the
>ones displayed in the future).
>
>Test plan:
>Have more than 20 reports defined
>Go on the report list view, then change the number of elements
>displayed, click "action>delete". You should get a warn.
>
>Signed-off-by: Liz Rea <liz@catalyst.net.nz>
>Confirm that there is now a confirmation on delete from the list -> action menu
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 6125814..1655d92 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -157,7 +157,7 @@ $(document).ready(function(){
>     });
> [% END %]
> 
>-    $(".confirmdelete").click(function(){
>+    $("#table_reports").delegate(".confirmdelete", 'click', function(){
>         $(this).parents('tr').attr("class","warn");
>         if(confirm(_("Are you sure you want to delete this saved report?"))){
>             return true;
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 15299: 46389 | 46413 | 46428