Attachment 46422 Details for Bug 15501 – Bug 15501 - Planned Irregularities are deleted when modifying subscription

[patch] Bug 15501 - Planned Irregularities are deleted when modifying subscription

Bug-15501---Planned-Irregularities-are-deleted-whe.patch (text/plain), 1.70 KB, created by Kyle M Hall (khall) on 2016-01-08 12:36:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2016-01-08 12:36:27 UTC

Size: 1.70 KB

patch

obsolete

>From ba8a47a996f228937268074074852fa649578002 Mon Sep 17 00:00:00 2001
>From: Lyon3 Team <koha@univ-lyon3.fr>
>Date: Thu, 7 Jan 2016 10:48:42 +0100
>Subject: [PATCH] Bug 15501 - Planned Irregularities are deleted when modifying
> subscription
>
>Add a warning to avoid saving a subscription whitout testing prediction pattern
>when there are planned no published issues
>
>Signed-off-by: Liz Rea <liz@catalyst.net.nz>
>Ran through test plan, looks all good.
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>index af908df..136aa57 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>@@ -17,6 +17,7 @@ var globalnumpatterndata;
> var globalfreqdata;
> var advancedpatternlocked;
> var patternneedtobetested = 0;
>+[% IF ( irregularity ) %]patternneedtobetested=1[% END %]
> 
> function check_issues(){
>     if (globalfreqdata.unit.length >0) {
>@@ -86,7 +87,9 @@ function Check_page2(){
>         return false;
>     }
>     if(patternneedtobetested){
>-        alert(_("Please click on 'Test prediction pattern' before saving subscription."));
>+        [% IF (irregularity) %]
>+           alert(_("Warning ! Present pattern has planned irregularities. Click on 'Test prediction pattern' to check if it's still valid"));
>+        [% ELSE %]alert(_("Please click on 'Test prediction pattern' before saving subscription."));[% END %]
>         return false;
>     }
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 15501: 46341 | 46385 | 46411 | 46422