Bugzilla – Attachment 46474 Details for
Bug 10988
Allow login via Google OAuth2 (OpenID Connect)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Remove some outdated wording from googleopenidconnect
0002-Bug-10988-Fix-some-wording.patch (text/plain), 1.29 KB, created by
Nicholas van Oudtshoorn
on 2016-01-11 09:02:15 UTC
(
hide
)
Description:
Remove some outdated wording from googleopenidconnect
Filename:
MIME Type:
Creator:
Nicholas van Oudtshoorn
Created:
2016-01-11 09:02:15 UTC
Size:
1.29 KB
patch
obsolete
>From a5d5f37ade0b3bb433595d604eeb39f9720b2820 Mon Sep 17 00:00:00 2001 >From: Nicholas van Oudtshoorn <vanoudt@gmail.com> >Date: Mon, 11 Jan 2016 17:01:02 +0800 >Subject: [PATCH 2/2] Bug 10988 - Fix some wording Fix some outdated wording in > googleopenidconnect > >--- > opac/svc/auth/googleopenidconnect | 7 ------- > 1 file changed, 7 deletions(-) > >diff --git a/opac/svc/auth/googleopenidconnect b/opac/svc/auth/googleopenidconnect >index 8b91c27..ab71918 100755 >--- a/opac/svc/auth/googleopenidconnect >+++ b/opac/svc/auth/googleopenidconnect >@@ -19,9 +19,6 @@ > # > # > # Basic OAuth2/OpenID Connect authentication for google goes like this >-# First: >-# get your clientid, clientsecret from google. At this stage, tell >-# google that your redirect url is /cgi-bin/koha/svc/oauthlogin > # > # The first thing that happens when this script is called is > # that one gets redirected to an authentication url from google >@@ -32,10 +29,6 @@ > # round-trip back to google to decrypt. Finally, we can extract > # the email address from this. > # >-# There is some room for improvement here. In particular, Google >-# recommends verifying and decrypting the id_token locally, which >-# means caching some information and updating it daily. But that >-# would make things a lot faster > > use Modern::Perl; > use CGI qw ( -utf8 escape ); >-- >2.4.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10988
:
21740
|
21936
|
21938
|
21939
|
25343
|
25570
|
25684
|
29594
|
29595
|
30014
|
30015
|
36354
|
36355
|
40087
|
40252
|
40442
|
40979
|
41663
|
43791
|
43792
|
43938
|
45667
|
45668
|
45895
|
46016
|
46473
|
46474
|
47780
|
47781
|
47782
|
49785
|
49786
|
49787