Attachment 46560 Details for Bug 14641 – Bug 14641: [SIGNED-OFF] Warns in subscription-add.pl

[patch] Bug 14641: [SIGNED-OFF] Warns in subscription-add.pl

Bug-14641-SIGNED-OFF-Warns-in-subscription-addpl.patch (text/plain), 995 bytes, created by Magnus Enger on 2016-01-12 19:14:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Magnus Enger

Created: 2016-01-12 19:14:12 UTC

Size: 995 bytes

patch

obsolete

>From c3f7eaf91f33501202a482a030df108be75f7938 Mon Sep 17 00:00:00 2001
>From: Aleisha <aleishaamohia@hotmail.com>
>Date: Mon, 11 Jan 2016 21:15:46 +0000
>Subject: [PATCH] Bug 14641: [SIGNED-OFF] Warns in subscription-add.pl
>
>Removes warn using Jonathan's suggestion!
>
>To test:
>1) Reproduce warns by clicking New Subscription
>2) Apply patch
>3) Click New Subscription again
>4) Confirm warns are gone
>
>Signed-off-by: Magnus Enger <magnus@libriotech.no>
>Patch removes the warn that come when clicking "New subscription"
>---
> serials/subscription-add.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/serials/subscription-add.pl b/serials/subscription-add.pl
>index 7525b59..31a1e35 100755
>--- a/serials/subscription-add.pl
>+++ b/serials/subscription-add.pl
>@@ -236,6 +236,7 @@ if ($op eq 'addsubscription') {
> 
> sub get_letter_loop {
>     my ($selected_lettercode) = @_;
>+    $selected_lettercode //= '';
>     my $letters = GetLetters({ module => 'serial' });
>     return [
>         map {
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14641: 41325 | 45623 | 46500 | 46560 | 46580