Bugzilla – Attachment 46566 Details for
Bug 5501
Improve the 'do not notify' option
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 5501 - Improve the 'do not notify' option. HOLD-letter.
Bug-5501---Improve-the-do-not-notify-option-HOLD-l.patch (text/plain), 1.35 KB, created by
Aleisha Amohia
on 2016-01-12 22:54:09 UTC
(
hide
)
Description:
Bug 5501 - Improve the 'do not notify' option. HOLD-letter.
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2016-01-12 22:54:09 UTC
Size:
1.35 KB
patch
obsolete
>From a24e80fcf36d8b4b61857524df7d2165b6cf1ac5 Mon Sep 17 00:00:00 2001 >From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> >Date: Tue, 20 Jan 2015 20:49:18 +0200 >Subject: [PATCH] Bug 5501 - Improve the 'do not notify' option. HOLD-letter. > >TEST PLAN: >1. Find a Borrower and edit "Patron messaging preferences". >2. Check the "Do not notify" for "Hold filled" -letter. >3. Check any other checkboxes for "Hold filled" -letter. > The "Do not notify"-checkbox should get unchecked. >4. Check the "Do not notify" -checkbox again for the "Hold filled" -letter. > Other selections for the row get unchecked. >5. Save changes. >6. Make a hold for a borrower. >7. Check-in the reserved Item and catch the hold. >8. In the notices-tab for the Borrower, there should be no message for the > borrower about getting the caught Hold. > >Signed-off-by: Aleisha <aleishaamohia@hotmail.com> >--- > C4/Reserves.pm | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 7bb5d69..b6b9c8d 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -1982,6 +1982,9 @@ sub _koha_notify_reserve { > message_name => 'Hold_Filled' > } ); > >+ #The Borrower can opt out from any notifications. This is explicit rejection. >+ return if $messagingprefs->{transports}->{none}; >+ > my $sth = $dbh->prepare(" > SELECT * > FROM reserves >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5501
:
35413
|
35414
| 46566