Bugzilla – Attachment 46611 Details for
Bug 14610
Add ability to place article requests in Koha
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14610 [QA Followup] - Add "All libraries" option to article-requests.pl
Bug-14610-QA-Followup---Add-All-libraries-option-t.patch (text/plain), 2.18 KB, created by
Kyle M Hall (khall)
on 2016-01-13 16:45:59 UTC
(
hide
)
Description:
Bug 14610 [QA Followup] - Add "All libraries" option to article-requests.pl
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-01-13 16:45:59 UTC
Size:
2.18 KB
patch
obsolete
>From 8efc3c4f841f915a97f754b3b08cd20d22ddd133 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 13 Jan 2016 16:04:53 +0000 >Subject: [PATCH] Bug 14610 [QA Followup] - Add "All libraries" option to > article-requests.pl > >--- > circ/article-requests.pl | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt | 5 ++++- > 2 files changed, 5 insertions(+), 2 deletions(-) > >diff --git a/circ/article-requests.pl b/circ/article-requests.pl >index 816c736..d0c2805 100755 >--- a/circ/article-requests.pl >+++ b/circ/article-requests.pl >@@ -36,7 +36,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > } > ); > >-my $branchcode = $query->param('branchcode') || C4::Context->userenv->{'branch'}; >+my $branchcode = defined( $query->param('branchcode') ) ? $query->param('branchcode') : C4::Context->userenv->{'branch'}; > > $template->param( > branchcode => $branchcode, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt >index 9dfd2ab..8e8b994 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt >@@ -122,6 +122,7 @@ > > <form id="ar-branchcode-form" method="post"> > <select name="branchcode" id="branchcode"> >+ <option value="">All libraries</option> > [% FOREACH b IN Branches.all %] > [% IF b.branchcode == branchcode %] > <option value="[% b.branchcode %]" selected="selected">[% b.branchname %]</option> >@@ -130,7 +131,9 @@ > [% END %] > [% END %] > </select> >- <input class="btn btn-small" type="submit" value="Update" /> >+ <button type="submit" class="btn btn-small" type="submit"> >+ <i class="fa fa-refresh"></i> Update >+ </button> > </form> > > <div id="article-request-tabs" class="toptabs"> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14610
:
42822
|
42823
|
42824
|
42825
|
42826
|
42827
|
42828
|
42829
|
43198
|
43199
|
43200
|
43201
|
43202
|
43264
|
43265
|
43266
|
43267
|
43268
|
43270
|
43271
|
43272
|
43273
|
43274
|
43278
|
43279
|
43280
|
43281
|
43282
|
43654
|
43655
|
43656
|
43657
|
43658
|
44219
|
44220
|
44221
|
44222
|
44223
|
44224
|
44225
|
44226
|
44227
|
44228
|
44229
|
44230
|
44231
|
44232
|
44233
|
44234
|
44235
|
44236
|
44237
|
44238
|
44239
|
44240
|
44241
|
44242
|
44916
|
44917
|
44918
|
44919
|
44920
|
44921
|
44922
|
44923
|
44924
|
44925
|
44926
|
45946
|
45947
|
45948
|
45949
|
45950
|
45951
|
45952
|
45953
|
45954
|
45955
|
45956
|
46518
|
46519
|
46520
|
46521
|
46522
|
46523
|
46524
|
46525
|
46526
|
46527
|
46528
|
46529
|
46530
|
46595
|
46596
|
46597
|
46598
|
46599
|
46600
|
46601
|
46602
|
46603
|
46604
|
46605
|
46606
|
46607
|
46608
|
46609
|
46610
|
46611
|
46612
|
47905
|
47906
|
47907
|
47908
|
47909
|
47910
|
47911
|
47912
|
47913
|
47914
|
47915
|
47916
|
47917
|
47918
|
47919
|
47920
|
47921
|
47922
|
48177
|
48178
|
48179
|
48180
|
48181
|
48182
|
48212
|
48213
|
48214
|
48215
|
48216
|
48217
|
48218
|
50348
|
50349
|
50350
|
50351
|
50352
|
50353
|
50354
|
51527
|
51528
|
51529
|
51530
|
51531
|
51532
|
51533
|
51534
|
51778
|
51779
|
51780
|
51781
|
51782
|
51783
|
52688
|
52689
|
52690
|
52691
|
52692
|
52693
|
55556
|
55557
|
55558
|
55559
|
55560
|
55561
|
55568
|
55569
|
56084
|
56085
|
56086
|
56087
|
56088
|
56089
|
56090
|
56318
|
56319
|
56320
|
56321
|
56322
|
56323
|
56324
|
56325
|
56326
|
56327
|
56328
|
56775
|
56776
|
56777
|
56778
|
56779
|
56780
|
56781
|
56782
|
56783
|
56784
|
56785
|
56816
|
56854
|
56855
|
56856
|
56857
|
56858
|
56859
|
56860
|
56861
|
56862
|
56863
|
56864
|
56865