Bugzilla – Attachment 4665 Details for
Bug 6602
Reports dictionary doesn't properly recognize text columns
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Fix-for-Bug-6602-Reports-dictionary-doesn-t-properly.patch (text/plain), 1.11 KB, created by
Owen Leonard
on 2011-07-18 19:43:25 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2011-07-18 19:43:25 UTC
Size:
1.11 KB
patch
obsolete
>From c9cdaff2bb95be96cb18cf11c200e3d86e44e0ba Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 18 Jul 2011 15:38:13 -0400 >Subject: [PATCH] Fix for Bug 6602 - Reports dictionary doesn't properly recognize text columns >Content-Type: text/plain; charset="utf-8" > >Reports dictionary won't let you set a comparison for MEDIUMTEXT columns. To >test, choose a MEDIUMTEXT column like borrowers.surname in Step 3 of adding >a new dictionary definition. Before the patch, in Step 4 you would not see >any kind of form field for entering a comparison. After patching Step 4 will >offer you a field labeled "Search string matches." >--- > reports/dictionary.pl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/reports/dictionary.pl b/reports/dictionary.pl >index 393c917..4f94d69 100755 >--- a/reports/dictionary.pl >+++ b/reports/dictionary.pl >@@ -115,7 +115,7 @@ elsif ($phase eq 'New Term step 4'){ > if ($type eq 'DATE' || $type eq 'DATETIME'){ > $tmp_hash{'date'}=1; > } >- if ($type eq 'TEXT'){ >+ if ($type eq 'TEXT' || $type eq 'MEDIUMTEXT'){ > $tmp_hash{'text'}=1; > } > # else { >-- >1.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6602
:
4665
|
4996
|
4997
|
13569
|
13698
|
13798