Bugzilla – Attachment 46761 Details for
Bug 15416
Warns on Guided Reports page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15416: Warns on guided_reports.pl
Bug-15416-Warns-on-guidedreportspl.patch (text/plain), 922 bytes, created by
Aleisha Amohia
on 2016-01-18 03:33:01 UTC
(
hide
)
Description:
Bug 15416: Warns on guided_reports.pl
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2016-01-18 03:33:01 UTC
Size:
922 bytes
patch
obsolete
>From 4526e2b65d39ff256d83e17982bdfbe00928689f Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Mon, 18 Jan 2016 03:30:44 +0000 >Subject: [PATCH] Bug 15416: Warns on guided_reports.pl > >Initialising $phase variable to be '' if not defined. > >To test: >1) Go to Reports -> Guided Reports Wizard >2) Notice warns >3) Apply patch >4) Refresh page >5) Confirm warns are gone and page still works as it should >--- > reports/guided_reports.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl >index 6a03e11..8ba701f 100755 >--- a/reports/guided_reports.pl >+++ b/reports/guided_reports.pl >@@ -48,6 +48,7 @@ my $input = new CGI; > my $usecache = C4::Context->ismemcached; > > my $phase = $input->param('phase'); >+$phase //= ''; > my $flagsrequired; > if ( $phase eq 'Build new' or $phase eq 'Delete Saved' ) { > $flagsrequired = 'create_reports'; >-- >1.7.10.4
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=46761">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15416
:
46761
|
47568
|
47579