Bugzilla – Attachment 46833 Details for
Bug 14752
Add multiple copies to a basket at once
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14752 - (QA Followup) Use input type="number" and small update to error modal
Bug-14752---QA-Followup-Use-input-typenumber-and-s.patch (text/plain), 3.33 KB, created by
Briana Greally
on 2016-01-18 23:23:44 UTC
(
hide
)
Description:
Bug 14752 - (QA Followup) Use input type="number" and small update to error modal
Filename:
MIME Type:
Creator:
Briana Greally
Created:
2016-01-18 23:23:44 UTC
Size:
3.33 KB
patch
obsolete
>From 22de913ae4b46247a3092432ba26d86626dd697d Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 8 Jan 2016 15:51:48 +0000 >Subject: [PATCH] Bug 14752 - (QA Followup) Use input type="number" and small > update to error modal > >Signed-off-by: Briana <brianagreally@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/js/additem.js | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/additem.js b/koha-tmpl/intranet-tmpl/prog/en/js/additem.js >index a533734..0261012 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/additem.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/additem.js >@@ -180,7 +180,7 @@ function cloneItemBlock(index, unique_item_fields, callback) { > buttonPlus += '<input type="button" class="addItemControl" name="buttonPlus" style="cursor:pointer; margin:0 1em;" onclick="addItem(this,\'' + unique_item_fields + '\')" value="' + (window.MSG_ADDITEM_JS_ADDITEM || 'Add item')+ '" />'; > buttonPlus += '<input type="button" class="addItemControl cancel" name="buttonClear" style="cursor:pointer;" onclick="clearItemBlock(this)" value="' + (window.MSG_ADDITEM_JS_CLEAR || 'Clear')+ '" />'; > buttonPlus += '<input type="button" class="addItemControl" name="buttonPlusMulti" data-toggle="modal" data-target="#uniqueFieldsModal" onclick="javascript:this.nextSibling.style.visibility=\'visible\';document.f.multiValue.focus(); return false;" style="cursor:pointer; margin:0 1em;" value="' + (window.MSG_ADDITEM_JS_ADDMULTI || 'Add multiple items')+ '" />'; >- buttonPlus +='<span id="add_multiple_copies" style="visibility:hidden"><input type="textbox" class="addItemControl" id="multiValue" name="multiValue" placeholder="'+window.MSG_ADDITEM_JS_MULTIVAL+'" /><input type="button" class="addItemControl" name=buttonAddMulti" style="cursor:pointer; margin:0 1em;" onclick="checkCount( this ,\'' + unique_item_fields + '\')" value="' + (window.MSG_ADDITEM_JS_SUBMITMULTI || 'Add') + '" /></span>'; >+ buttonPlus +='<span id="add_multiple_copies" style="visibility:hidden"><input type="number" class="addItemControl" id="multiValue" name="multiValue" placeholder="'+window.MSG_ADDITEM_JS_MULTIVAL+'" /><input type="button" class="addItemControl" name=buttonAddMulti" style="cursor:pointer; margin:0 1em;" onclick="checkCount( this ,\'' + unique_item_fields + '\')" value="' + (window.MSG_ADDITEM_JS_SUBMITMULTI || 'Add') + '" /></span>'; > buttonPlus += "</fieldset>"; > $(clone).append(buttonPlus); > /* Copy values from the original block (input) */ >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >index acf3872..016da92 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >@@ -662,7 +662,8 @@ $(document).ready(function() > [% END %] > > <div id="multiCountModal" class="modal hide fade" aria-labelledby="multiCountModal" aria-hidden="true"> >- <h3>You must enter a valid number to add multiple copies</h3> >+ <h3>Invalid number of copies</h3> >+ <p>Please enter a <b>number</b>, greater than 1</p> > </div> > > </div> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14752
:
46093
|
46439
|
46832
|
46833
|
47223
|
47252
|
47477
|
48254
|
51481
|
52083
|
52587
|
52588
|
52605
|
52606
|
55527
|
55528
|
56649
|
56684