Attachment 46846 Details for Bug 14930 – 14930 - Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature To Test - - Borrower has some fines and checkouts - Leave OPACFineNoRenewals empty/blank - Try to renew items in the OPAC - notice error message - Add a big value to Opac

[patch] 14930 - Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature To Test - - Borrower has some fines and checkouts - Leave OPACFineNoRenewals empty/blank - Try to renew items in the OPAC - notice error message - Add a big value to Opac

14930---Leaving-OpacFineNoRenewals-blank-blocks-re.patch (text/plain), 1.33 KB, created by Gus Ellerm on 2016-01-19 03:17:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Gus Ellerm

Created: 2016-01-19 03:17:57 UTC

Size: 1.33 KB

patch

obsolete

>From 029a7a0d4515c31fceb558a5621354c039e25997 Mon Sep 17 00:00:00 2001
>From: Gus <gel1163@stacmail.net>
>Date: Tue, 19 Jan 2016 03:12:48 +0000
>Subject: [PATCH] 14930 - Leaving OpacFineNoRenewals blank blocks renewals,
> but should disable feature To Test - - Borrower has some
> fines and checkouts - Leave OPACFineNoRenewals empty/blank
> - Try to renew items in the OPAC - notice error message -
> Add a big value to OpacFineNoRenewals - notice renewals
> work Leaving the OPACFineNoRenewals empty will dissable the
> feature.
>
>---
> opac/opac-user.pl |    5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/opac/opac-user.pl b/opac/opac-user.pl
>index 9d1f9b2..e4939d8 100755
>--- a/opac/opac-user.pl
>+++ b/opac/opac-user.pl
>@@ -107,9 +107,10 @@ if ( 5 >= $borr->{'amountoutstanding'} && $borr->{'amountoutstanding'} > 0 ) {
>     $borr->{'amountoverzero'} = 1;
> }
> my $no_renewal_amt = C4::Context->preference( 'OPACFineNoRenewals' );
>-$no_renewal_amt ||= 0;
>+$no_renewal_amt ||= undef;
> 
>-if (  C4::Context->preference( 'OpacRenewalAllowed' ) && $borr->{amountoutstanding} > $no_renewal_amt ) {
>+warn "Renwal amount = $no_renewal_amt";
>+if (  C4::Context->preference( 'OpacRenewalAllowed' ) && $no_renewal_amt && $borr->{amountoutstanding} > $no_renewal_amt ) {
>     $borr->{'flagged'} = 1;
>     $canrenew = 0;
>     $template->param(
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14930: 46845 | 46846 | 47271 | 47466 | 47652 | 47653 | 47792 | 47793