Attachment 46876 Details for Bug 14310 – Bug 14310 [QA Follow] - Remove FIXME, add explanation comment instead

[patch] Bug 14310 [QA Follow] - Remove FIXME, add explanation comment instead

Bug-14310-QA-Follow---Remove-FIXME-add-explanation.patch (text/plain), 1.03 KB, created by Kyle M Hall (khall) on 2016-01-19 14:16:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2016-01-19 14:16:16 UTC

Size: 1.03 KB

patch

obsolete

>From 039250924a1d68fe9f04444745399dd5b931f3bc Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 19 Jan 2016 14:16:22 +0000
>Subject: [PATCH] Bug 14310 [QA Follow] - Remove FIXME, add explanation comment
> instead
>
>---
> C4/Reserves.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index 8794ea8..f981be1 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -1176,8 +1176,8 @@ sub ModReserve {
>                 $suspend_until = eval { dt_from_string( $suspend_until ) };
>                 $hold->suspend_hold( $suspend_until );
>             } else {
>-                # FIXME: Why are we doing this? Should this be resuming the hold,
>-                # or maybe suspending it indefinitely?
>+                # If the hold is suspended leave the hold suspended, but convert it to an indefinite hold.
>+                # If the hold is not suspended, this does nothing.
>                 $hold->set( { suspend_until => undef } )->store();
>             }
>         }
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 14310: 39750 | 39751 | 39752 | 39753 | 39754 | 40024 | 40030 | 40031 | 40034 | 43525 | 43526 | 43830 | 43831 | 43832 | 43978 | 44203 | 44204 | 44205 | 44206 | 44207 | 46857 | 46858 | 46859 | 46860 | 46861 | 46862 | 46870 | 46871 | 46872 | 46873 | 46874 | 46875 | 46876