Bugzilla – Attachment 46902 Details for
Bug 15601
TestBuilder tests are failing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15601: Fix TestBuilder tests
Bug-15601-Fix-TestBuilder-tests.patch (text/plain), 1.88 KB, created by
Kyle M Hall (khall)
on 2016-01-19 15:33:25 UTC
(
hide
)
Description:
Bug 15601: Fix TestBuilder tests
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-01-19 15:33:25 UTC
Size:
1.88 KB
patch
obsolete
>From be43b8a882cf8ba39e0bcf00bf295b6c3e7d6cad Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 19 Jan 2016 15:10:42 +0000 >Subject: [PATCH] Bug 15601: Fix TestBuilder tests > >Bug 13624 modified the DB structure for overduerules. >The TestBuilder tests (t/db_dependent/TestBuilder.t) based some of its >checks on this structure. > >Test plan: > prove t/db_dependent/TestBuilder.t >Should return green. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > t/db_dependent/TestBuilder.t | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > >diff --git a/t/db_dependent/TestBuilder.t b/t/db_dependent/TestBuilder.t >index 638d2ef..a3cb813 100644 >--- a/t/db_dependent/TestBuilder.t >+++ b/t/db_dependent/TestBuilder.t >@@ -19,7 +19,7 @@ > > use Modern::Perl; > >-use Test::More tests => 42; >+use Test::More tests => 41; > > use Koha::Database; > >@@ -49,8 +49,7 @@ my $my_overduerules_transport_type = { > message_transport_type => { > message_transport_type => 'my msg_t_t', > }, >- letternumber => 1, >- branchcode => { >+ overduerules_id => { > branchcode => 'codeB', > categorycode => 'codeC', > }, >@@ -67,11 +66,6 @@ is( > 'build stores the message_transport_type correctly' > ); > is( >- $overduerules_transport_type->{letternumber}, >- $my_overduerules_transport_type->{letternumber}, >- 'build stores the letternumber correctly' >-); >-is( > $overduerules_transport_type->{branchcode}, > $my_overduerules_transport_type->{branchcode}->{branchcode}, > 'build stores the branchcode correctly' >@@ -102,7 +96,7 @@ is_deeply( > 'build links the branchcode and the categorycode correctly' > ); > isnt( >- $overduerules_transport_type->{_fk}->{branchcode}->{letter2}, >+ $overduerules_transport_type->{_fk}->{overduerules_id}->{letter2}, > undef, > 'build generates values if they are not given' > ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15601
:
46898
|
46902
|
46954