Attachment 46909 Details for Bug 14538 – Bug 14538: editing perl doc for CalcFine

[patch] Bug 14538: editing perl doc for CalcFine

Bug-14538-editing-perl-doc-for-CalcFine.patch (text/plain), 1.85 KB, created by Jonathan Druart on 2016-01-19 16:33:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-01-19 16:33:01 UTC

Size: 1.85 KB

patch

obsolete

>From b7b44a3a430d50e3a8b90cecb462fa262159a628 Mon Sep 17 00:00:00 2001
>From: Natasha <tasham_8@hotmail.com>
>Date: Mon, 18 Jan 2016 22:59:03 +0000
>Subject: [PATCH] Bug 14538: editing perl doc for CalcFine
>
>To Test:
>Read perldoc C4/Overdues.pm
>Confirm that it says CalcFine returns four values and that rest of the documentation is correct
>
>NOTE: only a little visual ugliness, but definitely an improvement.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> C4/Overdues.pm | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/C4/Overdues.pm b/C4/Overdues.pm
>index f5e7d17..37711ba 100644
>--- a/C4/Overdues.pm
>+++ b/C4/Overdues.pm
>@@ -204,7 +204,7 @@ sub checkoverdues {
> 
> =head2 CalcFine
> 
>-    ($amount, $chargename,  $daycounttotal) = &CalcFine($item,
>+    ($amount, $chargename,  $units_minus_grace, $chargeable_units) = &CalcFine($item,
>                                   $categorycode, $branch,
>                                   $start_dt, $end_dt );
> 
>@@ -236,10 +236,10 @@ C<$amount> is the fine owed by the patron (see above).
> C<$chargename> is the chargename field from the applicable record in
> the categoryitem table, whatever that is.
> 
>-C<$unitcount> is the number of chargeable units (days between start and end dates, Calendar adjusted where needed,
>-minus any applicable grace period, or hours)
>+C<$units_minus_grace> is the number of chargeable units minus the grace period
> 
>-FIXME - What is chargename supposed to be ?
>+C<$chargeable_units> is the number of chargeable units (days between start and end dates, Calendar adjusted where needed,
>+minus any applicable grace period, or hours)
> 
> FIXME: previously attempted to return C<$message> as a text message, either "First Notice", "Second Notice",
> or "Final Notice".  But CalcFine never defined any value.
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 14538: 46831 | 46907 | 46909