Bugzilla – Attachment 46941 Details for
Bug 14193
Accessibility: Searching patrons using the alphabetic index doesn't work
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14193 - Accessibility: Searching patrons using the alphabetic index doesn't work
Bug-14193---Accessibility-Searching-patrons-using-.patch (text/plain), 3.43 KB, created by
Briana Greally
on 2016-01-19 21:05:34 UTC
(
hide
)
Description:
Bug 14193 - Accessibility: Searching patrons using the alphabetic index doesn't work
Filename:
MIME Type:
Creator:
Briana Greally
Created:
2016-01-19 21:05:34 UTC
Size:
3.43 KB
patch
obsolete
>From 9d428508fca36cd0a4b1add23d300237431fd80c Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 19 Jan 2016 11:36:44 -0500 >Subject: [PATCH] Bug 14193 - Accessibility: Searching patrons using the > alphabetic index doesn't work > >Using a mouse to click on the alphabetic index letters works even though >the anchor markup doesn't contain an href attribute. However you >can't tab to them using the keyboard, and I assume the issue with >screen readers is related. > >This patch adds a dummy href attribute and a class-based click handler >so that we can get rid of the "onclick" attribute in the markup. > >To test, apply the patch and visit the "Patrons" section. > >1. Use the tab key to move the focus to one of the alphabet links. >2. Hit "Enter" and confirm that the search is performed correctly. >3. Click any of the alphabet links and confirm that clicking works as > well. >4. View the details of any patron and click the "Add child" button. >5. In the "Guarantor information" section click the "Change" button. >6. In the search popup, use the tab key to move the focus to one of the > alphabet links. >2. Hit "Enter" and confirm that the search is performed correctly. >3. Click any of the alphabet links and confirm that clicking works as > well. > >Signed-off-by: Briana <brianagreally@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt | 6 +++++- > koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 6 +++++- > 2 files changed, 10 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt >index 0a50e83..20af6d0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt >@@ -96,6 +96,10 @@ $(document).ready(function(){ > })); > > $("#searchform").on('submit', filter); >+ $(".filterByLetter").on("click",function(e){ >+ e.preventDefault(); >+ filterByFirstLetterSurname($(this).text()); >+ }); > }); > > function filter() { >@@ -197,7 +201,7 @@ function filterByFirstLetterSurname(letter) { > <div class="browse"> > Browse by last name: > [% FOREACH letter IN alphabet.split(' ') %] >- <a style="cursor:pointer" onclick="filterByFirstLetterSurname('[% letter %]');">[% letter %]</a> >+ <a href="#" class="filterByLetter">[% letter %]</a> > [% END %] > </div> > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >index 074555b..ad360ec 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >@@ -93,6 +93,10 @@ $(document).ready(function() { > }); > return true; > }); >+ $(".filterByLetter").on("click",function(e){ >+ e.preventDefault(); >+ filterByFirstLetterSurname($(this).text()); >+ }); > }); > > var dtMemberResults; >@@ -332,7 +336,7 @@ function filterByFirstLetterSurname(letter) { > <div class="browse"> > Browse by last name: > [% FOREACH letter IN alphabet.split(' ') %] >- <a style="cursor:pointer" onclick="filterByFirstLetterSurname('[% letter %]');">[% letter %]</a> >+ <a href="#" class="filterByLetter">[% letter %]</a> > [% END %] > </div> > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14193
:
46910
|
46941
|
46948