Attachment 47087 Details for Bug 6679 – Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm

[patch] Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm

Bug-6679---SIGNED-OFF-fix-2-perlcritic-violations-.patch (text/plain), 1.69 KB, created by Jonathan Druart on 2016-01-21 08:53:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-01-21 08:53:59 UTC

Size: 1.69 KB

patch

obsolete

>From 40a07511adb060e5fa75b2a9b44a3da30e819592 Mon Sep 17 00:00:00 2001
>From: Mason James <mtj@kohaaloha.com>
>Date: Wed, 27 Jun 2012 05:07:46 +1200
>Subject: [PATCH] Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in
> C4/Installer/PerlModules.pm
>
>Expression form of "eval" at line 71, column 9.  See page 161 of PBP.  (Severity: 5)
>
>Expression form of "eval" at line 85, column 13.  See page 161 of PBP.  (Severity: 5)
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/Installer/PerlModules.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Installer/PerlModules.pm b/C4/Installer/PerlModules.pm
>index 2f40cf5..655db74 100644
>--- a/C4/Installer/PerlModules.pm
>+++ b/C4/Installer/PerlModules.pm
>@@ -68,7 +68,7 @@ sub version_info {
>     my %params = @_;
>     if ($params{'module'}) {
>         return -1 unless grep {m/$params{'module'}/} keys(%$PERL_DEPS);
>-        eval "require $params{'module'}";
>+        eval {require $params{'module'}};
>         if ($@) {
>             return {$params{'module'} => {cur_ver => 0, min_ver => $PERL_DEPS->{$_}->{'min_ver'}, upgrade => 0, required => $PERL_DEPS->{$_}->{'required'}, usage => $PERL_DEPS->{$_}->{'usage'}}};
>         }
>@@ -82,7 +82,7 @@ sub version_info {
>     else {
>         for (sort keys(%{$PERL_DEPS})) {
>             my $pkg = $_;  #  $_ holds the string
>-            eval "require $pkg";
>+            eval {require $pkg};
>             if ($@) {
>                 push (@{$self->{'missing_pm'}}, {$_ => {cur_ver => 0, min_ver => $PERL_DEPS->{$_}->{'min_ver'}, required => $PERL_DEPS->{$_}->{'required'}, usage => $PERL_DEPS->{$_}->{'usage'}}});
>             }
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 6679: 4883 | 4884 | 4885 | 4886 | 4887 | 4888 | 5445 | 5446 | 5483 | 5487 | 6121 | 6122 | 6123 | 6139 | 6140 | 6141 | 6142 | 6143 | 6144 | 6270 | 6271 | 6663 | 6670 | 6675 | 6676 | 6677 | 6678 | 8542 | 8897 | 8898 | 8899 | 8950 | 8951 | 9746 | 9747 | 9748 | 9749 | 9750 | 10050 | 10051 | 10052 | 10053 | 10054 | 10075 | 10076 | 10077 | 10078 | 10079 | 10484 | 10485 | 10486 | 10487 | 10488 | 10489 | 10491 | 10492 | 10493 | 10494 | 10495 | 10496 | 10497 | 10499 | 10500 | 10501 | 10502 | 10503 | 10504 | 10505 | 10506 | 10507 | 10508 | 10509 | 10510 | 10512 | 10513 | 10514 | 10515 | 10517 | 10521 | 10522 | 10523 | 10524 | 10525 | 10526 | 10527 | 10935 | 10936 | 10938 | 10940 | 10944 | 10945 | 10946 | 10947 | 10948 | 10949 | 10950 | 10952 | 10953 | 10955 | 10957 | 10958 | 10959 | 10960 | 10961 | 10962 | 10963 | 10964 | 10965 | 10966 | 10967 | 10972 | 10976 | 10979 | 10980 | 10981 | 12224 | 12363 | 12490 | 12491 | 12492 | 34191 | 34192 | 34193 | 34194 | 34195 | 34196 | 34197 | 39100 | 39101 | 39102 | 39392 | 39393 | 39394 | 39395 | 39396 | 39397 | 39398 | 42770 | 47086 | 47087 | 47088 | 47089 | 47090 | 47178 | 47179 | 47180 | 47181 | 47205 | 47206 | 47207 | 47208