Bugzilla – Attachment 47135 Details for
Bug 9021
Add SMS via email as an alternative to SMS services via SMS::Send drivers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9021: Flag issues
Bug-9021-Flag-issues.patch (text/plain), 1.94 KB, created by
Mark Tompsett
on 2016-01-21 15:18:29 UTC
(
hide
)
Description:
Bug 9021: Flag issues
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2016-01-21 15:18:29 UTC
Size:
1.94 KB
patch
obsolete
>From ae6d767f4e3d4f69dcbf2dd3f10d90a644b878ab Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 1 Jan 2016 00:30:40 -0500 >Subject: [PATCH] Bug 9021: Flag issues > >Check in and check out were failing for me. >Specificly, the $borrower->{flags}->{...} was not accessible as >a hash, so I put a hash ref check around the code that would fail. > >TEST PLAN >--------- >1) Attempt a checkout > -- blows up with "1" not being allowed as a hash ref. >2) Apply patch >3) Attempt same checkout again > -- success >4) prove -v t/db_dependent/Circulation_dateexpiry.t > -- this triggers CanBookBeIssued > -- this should succeed >5) prove -v t/db_dependent/rollingloans.t > -- mine skipped the tests, but if configured, it > should also trigger and succeed. >6) run koha qa test tools > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > C4/Circulation.pm | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index ae53366..f30b385 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -812,14 +812,16 @@ sub CanBookBeIssued { > ModDateLastSeen( $item->{'itemnumber'} ); > return( { STATS => 1 }, {}); > } >- if ( $borrower->{flags}->{GNA} ) { >- $issuingimpossible{GNA} = 1; >- } >- if ( $borrower->{flags}->{'LOST'} ) { >- $issuingimpossible{CARD_LOST} = 1; >- } >- if ( $borrower->{flags}->{'DBARRED'} ) { >- $issuingimpossible{DEBARRED} = 1; >+ if ( ref $borrower->{flags} ) { >+ if ( $borrower->{flags}->{GNA} ) { >+ $issuingimpossible{GNA} = 1; >+ } >+ if ( $borrower->{flags}->{'LOST'} ) { >+ $issuingimpossible{CARD_LOST} = 1; >+ } >+ if ( $borrower->{flags}->{'DBARRED'} ) { >+ $issuingimpossible{DEBARRED} = 1; >+ } > } > if ( !defined $borrower->{dateexpiry} || $borrower->{'dateexpiry'} eq '0000-00-00') { > $issuingimpossible{EXPIRED} = 1; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9021
:
13290
|
13291
|
13293
|
13294
|
14166
|
14167
|
14363
|
15685
|
15687
|
15689
|
15691
|
16628
|
17311
|
21729
|
22478
|
28488
|
29927
|
32453
|
34180
|
34181
|
35816
|
40720
|
44331
|
45152
|
46163
|
46164
|
46165
|
46168
|
46169
|
46170
|
46171
|
47128
|
47129
|
47130
|
47133
|
47134
|
47135
|
47338
|
47339
|
47814
|
47815
|
47816
|
47817
|
47818
|
47845
|
47846
|
47847
|
47848
|
47995
|
48024
|
48025
|
48026
|
48027
|
48028
|
48029
|
48030
|
48031
|
48032
|
48033
|
48034
|
48035
|
48036
|
48052
|
48053
|
48054
|
48055
|
48056
|
48057
|
48058
|
48059
|
48060
|
48061
|
48062
|
48063
|
48064
|
48065
|
48066